[jira] Commented: (HADOOP-3122) test-patch target should check @SuppressWarnings(...)

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585019#action_12585019 ] 

Enis Soztutar commented on HADOOP-3122:
---------------------------------------

I think checking valid uses of @SuppressWarnings(...) in the current state of the code base is not trivial, because all the legacy code has not been converted to generics, which results in relatively high number of warnings. For example ReflectionUtils.newInstance() does not use generics, so every usage of it may introduce a warning. Moreover there are other classes ( WritableComparable, WritableComparator, to name a few ) that should be converted to generics to perform meaningful QA on usage of generics. 

> test-patch target should check @SuppressWarnings(...)
> -----------------------------------------------------
>
>                 Key: HADOOP-3122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3122
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>
> The Java annotation @SuppressWarnings(...) tag can be used to get rid of compiler warnings. In our patch process, QA should check @SuppressWarnings(...) tag to prevent abusing this tag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.