You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by lmnbeyond <lm...@gmail.com> on 2013/08/19 04:16:57 UTC
Pull requests
Hi all,
I want to do some contribution to Cordova, and I have tried to fix some minor issues:
repo: cordova-plugin-contacts
https://issues.apache.org/jira/browse/CB-4580
pull request: https://github.com/apache/cordova-plugin-contacts/pull/5/commits
repo: cordova-ios
https://issues.apache.org/jira/browse/CB-4567
pull request: https://github.com/apache/cordova-ios/pull/73/commits
repo: cordova-mobile-spec
https://issues.apache.org/jira/browse/CB-4568
pull request: https://github.com/apache/cordova-mobile-spec/pull/37/commits
repo:cordova-plugin-file
pull request: https://github.com/apache/cordova-plugin-file/pull/3/commits
I would really appreciate your time in reviewing my pull requests.
FYI: I have signed ICLA earlier.
Best Regards!
Re: Pull requests
Posted by lmnbeyond <lm...@gmail.com>.
Hi all,
That's right, my name is Meina Liu :)
Best Regards!
On 2013-8-20, at 上午4:10, Max Woghiren <ma...@google.com> wrote:
> I believe it's Meina Liu—the confirmation was sent on June 3rd.
>
> I'll pull these changes in.
>
> On Mon, Aug 19, 2013 at 4:07 PM, Andrew Grieve <ag...@chromium.org> wrote:
Re: Pull requests
Posted by Max Woghiren <ma...@google.com>.
I believe it's Meina Liu—the confirmation was sent on June 3rd.
I'll pull these changes in.
On Mon, Aug 19, 2013 at 4:07 PM, Andrew Grieve <ag...@chromium.org> wrote:
> Hi,
>
> All of your changes look good! Thanks! So that we can verify your ICLA, can
> you tell us what your name is?
>
> Cordova team - any volunteers for pulling these in? I'm away for a week on
> vacation starting pretty much now.
>
>
>
> On Sun, Aug 18, 2013 at 10:16 PM, lmnbeyond <lm...@gmail.com> wrote:
>
> > Hi all,
> >
> > I want to do some contribution to Cordova, and I have tried to fix
> > some minor issues:
> >
> > repo: cordova-plugin-contacts
> >
> > https://issues.apache.org/jira/browse/CB-4580
> >
> > pull request:
> > https://github.com/apache/cordova-plugin-contacts/pull/5/commits
> >
> >
> > repo: cordova-ios
> >
> > https://issues.apache.org/jira/browse/CB-4567
> >
> > pull request: https://github.com/apache/cordova-ios/pull/73/commits
> >
> >
> > repo: cordova-mobile-spec
> >
> > https://issues.apache.org/jira/browse/CB-4568
> >
> > pull request:
> > https://github.com/apache/cordova-mobile-spec/pull/37/commits
> >
> >
> > repo:cordova-plugin-file
> >
> > pull request:
> > https://github.com/apache/cordova-plugin-file/pull/3/commits
> >
> >
> > I would really appreciate your time in reviewing my pull requests.
> >
> > FYI: I have signed ICLA earlier.
> >
> >
> > Best Regards!
> >
> >
> >
> >
>
Re: Pull requests
Posted by Andrew Grieve <ag...@chromium.org>.
Hi,
All of your changes look good! Thanks! So that we can verify your ICLA, can
you tell us what your name is?
Cordova team - any volunteers for pulling these in? I'm away for a week on
vacation starting pretty much now.
On Sun, Aug 18, 2013 at 10:16 PM, lmnbeyond <lm...@gmail.com> wrote:
> Hi all,
>
> I want to do some contribution to Cordova, and I have tried to fix
> some minor issues:
>
> repo: cordova-plugin-contacts
>
> https://issues.apache.org/jira/browse/CB-4580
>
> pull request:
> https://github.com/apache/cordova-plugin-contacts/pull/5/commits
>
>
> repo: cordova-ios
>
> https://issues.apache.org/jira/browse/CB-4567
>
> pull request: https://github.com/apache/cordova-ios/pull/73/commits
>
>
> repo: cordova-mobile-spec
>
> https://issues.apache.org/jira/browse/CB-4568
>
> pull request:
> https://github.com/apache/cordova-mobile-spec/pull/37/commits
>
>
> repo:cordova-plugin-file
>
> pull request:
> https://github.com/apache/cordova-plugin-file/pull/3/commits
>
>
> I would really appreciate your time in reviewing my pull requests.
>
> FYI: I have signed ICLA earlier.
>
>
> Best Regards!
>
>
>
>