You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/21 01:19:15 UTC
Review Request: Time related refactoring changes. (libprocess)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11283/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
- Added a Time class as a new abstraction that works with Duration for various time related calculations. (libprocess)
- Added a Try<Time> Time::create(double secs) corresponding to the Duration::create() API. (libprocess)
Diffs
-----
third_party/libprocess/Makefile.am d9d9110cc75d71642e621097bbc8bdcb88fdc0f8
third_party/libprocess/include/process/clock.hpp 46b737dcd680a770193dbee9ba2ffd796ec48abd
third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7
third_party/libprocess/include/process/latch.hpp 4c7982fdcc53bbedc2ebe698acd1c29ffa16c0a2
third_party/libprocess/include/process/process.hpp 513431481a1c9d4f445958960cd001f2d1bb1c81
third_party/libprocess/include/process/statistics.hpp 3f56c078d8609041c80c312aa9a42ed24ca42e60
third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252
third_party/libprocess/src/process.cpp edcb684332590f0277bafb2d69de68413fc82828
third_party/libprocess/src/statistics.cpp e1fb319eff63e4b7a4c18dba43e4818018b0dd50
third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8daa042de127608bcb00b
third_party/libprocess/src/tests/statistics_tests.cpp d6a53f79c8afe4cccebed2274f3dfdd1fe540d02
Diff: https://reviews.apache.org/r/11283/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request: Time related refactoring changes. (libprocess)
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11283/#review20798
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On May 20, 2013, 11:19 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11283/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 11:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Added a Time class as a new abstraction that works with Duration for various time related calculations. (libprocess)
> - Added a Try<Time> Time::create(double secs) corresponding to the Duration::create() API. (libprocess)
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am d9d9110cc75d71642e621097bbc8bdcb88fdc0f8
> third_party/libprocess/include/process/clock.hpp 46b737dcd680a770193dbee9ba2ffd796ec48abd
> third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7
> third_party/libprocess/include/process/latch.hpp 4c7982fdcc53bbedc2ebe698acd1c29ffa16c0a2
> third_party/libprocess/include/process/process.hpp 513431481a1c9d4f445958960cd001f2d1bb1c81
> third_party/libprocess/include/process/statistics.hpp 3f56c078d8609041c80c312aa9a42ed24ca42e60
> third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252
> third_party/libprocess/src/process.cpp edcb684332590f0277bafb2d69de68413fc82828
> third_party/libprocess/src/statistics.cpp e1fb319eff63e4b7a4c18dba43e4818018b0dd50
> third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8daa042de127608bcb00b
> third_party/libprocess/src/tests/statistics_tests.cpp d6a53f79c8afe4cccebed2274f3dfdd1fe540d02
>
> Diff: https://reviews.apache.org/r/11283/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Time related refactoring changes. (libprocess)
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11283/
-----------------------------------------------------------
(Updated May 25, 2013, 12:26 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Added the two new files that got left out when split the large commit into three parts. The files were reviewed in previous reviews.
Description
-------
- Added a Time class as a new abstraction that works with Duration for various time related calculations. (libprocess)
- Added a Try<Time> Time::create(double secs) corresponding to the Duration::create() API. (libprocess)
Diffs (updated)
-----
third_party/libprocess/Makefile.am d9d9110cc75d71642e621097bbc8bdcb88fdc0f8
third_party/libprocess/include/process/clock.hpp 46b737dcd680a770193dbee9ba2ffd796ec48abd
third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7
third_party/libprocess/include/process/latch.hpp 4c7982fdcc53bbedc2ebe698acd1c29ffa16c0a2
third_party/libprocess/include/process/process.hpp 513431481a1c9d4f445958960cd001f2d1bb1c81
third_party/libprocess/include/process/statistics.hpp 3f56c078d8609041c80c312aa9a42ed24ca42e60
third_party/libprocess/include/process/time.hpp PRE-CREATION
third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252
third_party/libprocess/src/process.cpp edcb684332590f0277bafb2d69de68413fc82828
third_party/libprocess/src/statistics.cpp e1fb319eff63e4b7a4c18dba43e4818018b0dd50
third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8daa042de127608bcb00b
third_party/libprocess/src/tests/statistics_tests.cpp d6a53f79c8afe4cccebed2274f3dfdd1fe540d02
third_party/libprocess/src/tests/time_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/11283/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu