[GitHub] [incubator-nuttx] btashton commented on a change in pull request #3001: arch:riscv64:basic porting for C906.

[GitBox <gi...@apache.org>]

btashton commented on a change in pull request #3001:
URL: https://github.com/apache/incubator-nuttx/pull/3001#discussion_r591159689



##########
File path: arch/risc-v/src/c906/c906_clockconfig.c
##########
@@ -0,0 +1,86 @@
+/****************************************************************************
+ * arch/risc-v/src/c906/c906_clockconfig.c
+ *
+ * Derives from software originally provided by Canaan Inc
+ *
+ *   Copyright 2018 Canaan Inc

Review comment:
       Nothing from Canaan here this can be dropped.

##########
File path: arch/risc-v/src/c906/hardware/c906_clint.h
##########
@@ -0,0 +1,36 @@
+/****************************************************************************
+ * arch/risc-v/src/c906/hardware/c906_clint.h
+ *
+ * Derives from software originally provided by Canaan Inc
+ *
+ *   Copyright 2018 Canaan Inc

Review comment:
       There is nothing in this file that needs to be attributed to Canaan

##########
File path: arch/risc-v/src/c906/Make.defs
##########
@@ -0,0 +1,61 @@
+############################################################################
+# arch/risc-v/src/c906/Make.defs
+#
+#   Copyright (C) 2019 Masayuki Ishikawa. All rights reserved.

Review comment:
       @masayuki2009 has already filed a ICLA so we can drop this from the license header.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org