[jira] Commented: (SOLR-143) Support for PMD and Clover

["Yonik Seeley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470614 ] 

Yonik Seeley commented on SOLR-143:
-----------------------------------

While checking is nice, I'm not sure about requiring PMD before you can build Solr.
Is PMD better than the code inspections in IntelliJ/Eclipse?

> Support for PMD and Clover
> --------------------------
>
>                 Key: SOLR-143
>                 URL: https://issues.apache.org/jira/browse/SOLR-143
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Priority: Minor
>         Attachments: pmd-and-clover.diff
>
>
> had some time on a plane this weekend, so I adapted some of the clover hooks from Java-Lucene to Solr's build.xml and also put in hooks for running PMD (a bug pattern finding tool).
> the PMD hook actually teste the PMD ruleset twice, once warning about any violations, and once failing the build if any serious violations were found ... the goal would be to hook this into the "ant test" target so you can't successfully build if you have any serious rule violations.
> i strarted with a custom ruleset based on some of the bigger rules from PMD ... the theory being that as well clean up the code base we can add more nit-picky rules if we want to :)
> User is required to provide their own copy of PMD and/or clover on in an ANT_LIB. Clover requires (ASF committer) license, PMD is freely available...
> http://pmd.sourceforge.net/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.