You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/04/20 16:19:48 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #23756: test: cover empty AdvancedDataTypes internet_address and internet_port
sebastianliebscher opened a new pull request, #23756:
URL: https://github.com/apache/superset/pull/23756
### SUMMARY
This PR adds two tests for `AdvancedDataTypes` `internet_address` and `internet_port` when no value was passed in.
### TESTING INSTRUCTIONS
`pytest` or `./scripts/tests/run.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23756: test: cover empty AdvancedDataTypes internet_address and internet_port
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23756:
URL: https://github.com/apache/superset/pull/23756#issuecomment-1516623615
## [Codecov](https://codecov.io/gh/apache/superset/pull/23756?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23756](https://codecov.io/gh/apache/superset/pull/23756?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ada4102) into [master](https://codecov.io/gh/apache/superset/commit/60c9d68403b0bcefcc4ff7460ef4fde952d8f293?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60c9d68) will **decrease** coverage by `11.40%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ada4102 differs from pull request most recent head ba1806f. Consider uploading reports for the commit ba1806f to get more accurate results
```diff
@@ Coverage Diff @@
## master #23756 +/- ##
===========================================
- Coverage 68.08% 56.69% -11.40%
===========================================
Files 1923 1923
Lines 74140 74140
Branches 8103 8103
===========================================
- Hits 50481 42033 -8448
- Misses 21581 30029 +8448
Partials 2078 2078
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.17% <ø> (ø)` | |
| python | `59.48% <ø> (-23.70%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.06% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 304 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23756/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #23756: test: cover empty AdvancedDataTypes internet_address and internet_port
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #23756:
URL: https://github.com/apache/superset/pull/23756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org