You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Steve Hay <st...@uk.radan.com> on 2004/11/03 18:57:49 UTC
[PATCH] Re: mp2 build error on Win32
Joe Schaefer wrote:
>Steve Hay <st...@uk.radan.com> writes:
>
>
>
>>Current CVS mp2 doesn't build any more on Win32 :(
>>
>>
>
>[...]
>
>
>
>>mp2-1.99_17 works fine, and I'm damned if I can see what the cause of
>>the error is. The next few lines of output from the 1.99_17 build are:
>>
>>
>
>You need to look for "?=" appearing in a few of the Makefiles (not the
>top-level one). IIRC it's coming from a TEST_VERBOSE assignment, so it
>might be Test::Harness that's borked? Anyways, replacing them with "="
>seemed to let the Win32 build go through, but some of the tests failed
>for me.
>
Spot on!
Apache-Test and ModPerl-Registry Makefile's both have:
TEST_VERBOSE ?= 0
Deleting the "?" fixes it.
The attached patch removes the "?" from TestMM.pm, which seems to
prevent it from appearing in either of the above Makefile's. Not quite
sure I understand how it affects ModPerl-Registry, but there you go...
- Steve
------------------------------------------------
This email has been scanned for viruses and content by the Radan Computational Webshield Appliances.
Re: [PATCH] Re: mp2 build error on Win32
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Makefile(619) : fatal error U1000: syntax error : ')' missing in macro
> invocation
> Stop.
> NMAKE : fatal error U1077: 'cd' : return code '0x2'
> Stop.
rats, thanks for trying.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: mp2 build error on Win32
Posted by Steve Hay <st...@uk.radan.com>.
Geoffrey Young wrote:
>>Apache-Test and ModPerl-Registry Makefile's both have:
>>
>>TEST_VERBOSE ?= 0
>>
>>Deleting the "?" fixes it.
>>
>>
>
>ok, here is a different syntax, suggested by the GNU manual. can you win32
>guys give it a whirl and see if it works?
>
Sorry -- it doesn't:
Makefile(619) : fatal error U1000: syntax error : ')' missing in macro
invocation
Stop.
NMAKE : fatal error U1077: 'cd' : return code '0x2'
Stop.
- Steve
------------------------------------------------
This email has been scanned for viruses and content by the Radan Computational Webshield Appliances.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: mp2 build error on Win32
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Apache-Test and ModPerl-Registry Makefile's both have:
>
> TEST_VERBOSE ?= 0
>
> Deleting the "?" fixes it.
ok, here is a different syntax, suggested by the GNU manual. can you win32
guys give it a whirl and see if it works?
thanks
--Geoff
Re: [PATCH] Re: mp2 build error on Win32
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>>You need to look for "?=" appearing in a few of the Makefiles (not the
>>top-level one). IIRC it's coming from a TEST_VERBOSE assignment, so it
>>might be Test::Harness that's borked? Anyways, replacing them with "="
>>seemed to let the Win32 build go through, but some of the tests failed
>>for me.
>>
>
> Spot on!
>
> Apache-Test and ModPerl-Registry Makefile's both have:
>
> TEST_VERBOSE ?= 0
>
> Deleting the "?" fixes it.
blarg, that was me. from the log:
revision 1.42
date: 2004/10/26 01:42:14; author: geoff; state: Exp; lines: +1 -1
make sure TEST_VERBOSE respects the environment, not just the current
shell command.
somebody shout if ?= isn't portable
anyway, I reverted TestMM.pm back to 1.42. the issue I was trying to fix
was that if you do
$ make test TEST_VERBOSE=1
TEST_VERBOSE is respected. however, if you do
$ export TEST_VERBOSE=1
$ make test
TEST_VERBOSE is not respected.
a minor issue, sure, but one that was nagging me.
anyway, sorry for the late response, and thanks gozer for pinging me :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org