You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/08 11:41:16 UTC

[GitHub] [spark] panbingkun opened a new pull request, #38559: [SPARK-41050][BUILD] Upgrade scalafmt from 3.5.9 to 3.6.1

panbingkun opened a new pull request, #38559:
URL: https://github.com/apache/spark/pull/38559

   ### What changes were proposed in this pull request?
   The pr aims to upgrade scalafmt from 3.5.9 to 3.6.1
   
   ### Why are the changes needed?
   https://github.com/scalameta/scalafmt/compare/v3.5.9...v3.6.1
   <img width="582" alt="image" src="https://user-images.githubusercontent.com/15246973/200554901-ac6678f8-a865-4aae-bace-5a6ba4fc9804.png">
   <img width="595" alt="image" src="https://user-images.githubusercontent.com/15246973/200554977-1ad218df-d8b0-426f-ac71-0697852bbaec.png">
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   sh ./dev/scalafmt


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #38559: [SPARK-41050][BUILD] Upgrade scalafmt from 3.5.9 to 3.6.1

Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38559:
URL: https://github.com/apache/spark/pull/38559#issuecomment-1308019316

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on pull request #38559: [SPARK-41050][BUILD] Upgrade scalafmt from 3.5.9 to 3.6.1

Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #38559:
URL: https://github.com/apache/spark/pull/38559#issuecomment-1307225993

   > @panbingkun hmm... The changes is inconsistent with the title. Please revert the files that do not need to be change
   
   Err..., Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #38559: [SPARK-41050][BUILD] Upgrade scalafmt from 3.5.9 to 3.6.1

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38559:
URL: https://github.com/apache/spark/pull/38559#issuecomment-1307193108

   @panbingkun hmm... The changes is inconsistent with the title. Please revert the files that do not need to be change
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #38559: [SPARK-41050][BUILD] Upgrade scalafmt from 3.5.9 to 3.6.1

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #38559: [SPARK-41050][BUILD] Upgrade scalafmt from 3.5.9 to 3.6.1
URL: https://github.com/apache/spark/pull/38559


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org