[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #939: Support UpdateEvent for Update Operations

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #939:
URL: https://github.com/apache/incubator-iceberg/pull/939#discussion_r419553134



##########
File path: core/src/main/java/org/apache/iceberg/SnapshotManager.java
##########
@@ -127,6 +127,32 @@ public ManageSnapshots rollbackTo(long snapshotId) {
     return setCurrentSnapshot(snapshotId);
   }
 
+  @Override
+  public Object updateEvent() {
+    if (targetSnapshotId == null) {
+      // NOOP operation, no snapshot created
+      return null;
+    }
+
+    switch (managerOperation) {
+      case ROLLBACK:
+        // rollback does not create a new snapshot

Review comment:
       Yes. I'll create a followup for this. I presume this would be a specific Rollback event?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org