[jira] [Assigned] (OODT-951) Wrong null checker

["Chris A. Mattmann (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OODT-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann reassigned OODT-951:
--------------------------------------

    Assignee: Chris A. Mattmann

> Wrong null checker
> ------------------
>
>                 Key: OODT-951
>                 URL: https://issues.apache.org/jira/browse/OODT-951
>             Project: OODT
>          Issue Type: Bug
>          Components: workflow manager
>            Reporter: JC
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 1.9
>
>
> Hi
> In a recent Github snapshot, I've found a following code smell.
> Path: workflow/src/main/java/org/apache/oodt/cas/workflow/engine/PrioritizedQueueBasedWorkflowEngine.java
> {code}
> 69   public PrioritizedQueueBasedWorkflowEngine(WorkflowInstanceRepository repo    ,
> 70       PrioritySorter prioritizer, WorkflowLifecycleManager lifecycle,
> 71       EngineRunner runner, WorkflowRepository modelRepo, long querierWaitSec    onds) {
> 72     this.repo = repo;
> 73     this.prioritizer = prioritizer != null ? new HighestFIFOPrioritySorter(1    ,
> 74         50, 1) : prioritizer;
> 75     this.lifecycle = lifecycle;
> 76     this.modelRepo = modelRepo;
> {code}
> In Line 73, prioritizer != null should be prioritizer == null? This might be a trivial issue but wanted to report just in case.
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)