You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/24 09:24:27 UTC

[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #5994: [IOTDB-2919] Refactor delete storage group

cmlmakahts commented on code in PR #5994:
URL: https://github.com/apache/iotdb/pull/5994#discussion_r880274158


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/PartitionManager.java:
##########
@@ -65,12 +72,21 @@ public class PartitionManager {
 
   private SeriesPartitionExecutor executor;
 
+  private final ScheduledExecutorService regionCleaner;
+
   public PartitionManager(Manager configManager, PartitionInfo partitionInfo) {
     this.configManager = configManager;
     this.partitionInfo = partitionInfo;
+    this.regionCleaner =
+        IoTDBThreadPoolFactory.newSingleThreadScheduledExecutor("IoTDB-StorageGroup-Cleaner");
+    regionCleaner.scheduleAtFixedRate(this::clearDeletedStorageGroup, 10, 5, TimeUnit.SECONDS);

Review Comment:
   ok,I will extract it as a field and period will be set at 300s in next pr.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org