You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/24 17:58:25 UTC
[GitHub] [arrow] pitrou opened a new pull request #12242: ARROW-15433: [Doc] Fix warnings when building
pitrou opened a new pull request #12242:
URL: https://github.com/apache/arrow/pull/12242
This fixes a number of warnings emitted when building the Sphinx docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453
Benchmark runs are scheduled for baseline = 9fb6defaecd3df3bfd40519118ae248c85df16dd and contender = 231d0a6b30e7017f0e07162b6716f3da49a674d0. 231d0a6b30e7017f0e07162b6716f3da49a674d0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2093f71d480c44ea868e64e3591db557...708a4484bf054ea39e277489f07f327f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7b7a6c2ff5c64c7aab7e4f38910b7d6e...01cfa1661c444ba0a1ed9f1ff691cec8/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a8090f61e5464e149f9200bcd7161ee4...0e434b6c358342a3be2253a61c549839/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#discussion_r791019402
##########
File path: cpp/src/arrow/compute/api_aggregate.h
##########
@@ -46,7 +46,7 @@ class ExecContext;
class ARROW_EXPORT ScalarAggregateOptions : public FunctionOptions {
public:
explicit ScalarAggregateOptions(bool skip_nulls = true, uint32_t min_count = 1);
- constexpr static char const kTypeName[] = "ScalarAggregateOptions";
+ static constexpr char const kTypeName[] = "ScalarAggregateOptions";
Review comment:
I think it's fine, though it would be nice to get it fixed upstream eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453
Benchmark runs are scheduled for baseline = 9fb6defaecd3df3bfd40519118ae248c85df16dd and contender = 231d0a6b30e7017f0e07162b6716f3da49a674d0. 231d0a6b30e7017f0e07162b6716f3da49a674d0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2093f71d480c44ea868e64e3591db557...708a4484bf054ea39e277489f07f327f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7b7a6c2ff5c64c7aab7e4f38910b7d6e...01cfa1661c444ba0a1ed9f1ff691cec8/)
[Finished :arrow_down:0.22% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a8090f61e5464e149f9200bcd7161ee4...0e434b6c358342a3be2253a61c549839/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12242:
URL: https://github.com/apache/arrow/pull/12242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020381772
https://issues.apache.org/jira/browse/ARROW-15433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020381772
https://issues.apache.org/jira/browse/ARROW-15433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#discussion_r791016689
##########
File path: cpp/src/arrow/compute/api_aggregate.h
##########
@@ -46,7 +46,7 @@ class ExecContext;
class ARROW_EXPORT ScalarAggregateOptions : public FunctionOptions {
public:
explicit ScalarAggregateOptions(bool skip_nulls = true, uint32_t min_count = 1);
- constexpr static char const kTypeName[] = "ScalarAggregateOptions";
+ static constexpr char const kTypeName[] = "ScalarAggregateOptions";
Review comment:
This is working around a slightly silly parsing bug: https://github.com/michaeljones/breathe/issues/787
@lidavidm What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12242:
URL: https://github.com/apache/arrow/pull/12242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#discussion_r791019402
##########
File path: cpp/src/arrow/compute/api_aggregate.h
##########
@@ -46,7 +46,7 @@ class ExecContext;
class ARROW_EXPORT ScalarAggregateOptions : public FunctionOptions {
public:
explicit ScalarAggregateOptions(bool skip_nulls = true, uint32_t min_count = 1);
- constexpr static char const kTypeName[] = "ScalarAggregateOptions";
+ static constexpr char const kTypeName[] = "ScalarAggregateOptions";
Review comment:
I think it's fine, though it would be nice to get it fixed upstream eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453
Benchmark runs are scheduled for baseline = 9fb6defaecd3df3bfd40519118ae248c85df16dd and contender = 231d0a6b30e7017f0e07162b6716f3da49a674d0. 231d0a6b30e7017f0e07162b6716f3da49a674d0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2093f71d480c44ea868e64e3591db557...708a4484bf054ea39e277489f07f327f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7b7a6c2ff5c64c7aab7e4f38910b7d6e...01cfa1661c444ba0a1ed9f1ff691cec8/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a8090f61e5464e149f9200bcd7161ee4...0e434b6c358342a3be2253a61c549839/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453
Benchmark runs are scheduled for baseline = 9fb6defaecd3df3bfd40519118ae248c85df16dd and contender = 231d0a6b30e7017f0e07162b6716f3da49a674d0. 231d0a6b30e7017f0e07162b6716f3da49a674d0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2093f71d480c44ea868e64e3591db557...708a4484bf054ea39e277489f07f327f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7b7a6c2ff5c64c7aab7e4f38910b7d6e...01cfa1661c444ba0a1ed9f1ff691cec8/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a8090f61e5464e149f9200bcd7161ee4...0e434b6c358342a3be2253a61c549839/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#discussion_r791016689
##########
File path: cpp/src/arrow/compute/api_aggregate.h
##########
@@ -46,7 +46,7 @@ class ExecContext;
class ARROW_EXPORT ScalarAggregateOptions : public FunctionOptions {
public:
explicit ScalarAggregateOptions(bool skip_nulls = true, uint32_t min_count = 1);
- constexpr static char const kTypeName[] = "ScalarAggregateOptions";
+ static constexpr char const kTypeName[] = "ScalarAggregateOptions";
Review comment:
This is working around a slightly silly parsing bug: https://github.com/michaeljones/breathe/issues/787
@lidavidm What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12242: ARROW-15433: [Doc] Fix warnings when building
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453
Benchmark runs are scheduled for baseline = 9fb6defaecd3df3bfd40519118ae248c85df16dd and contender = 231d0a6b30e7017f0e07162b6716f3da49a674d0. 231d0a6b30e7017f0e07162b6716f3da49a674d0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2093f71d480c44ea868e64e3591db557...708a4484bf054ea39e277489f07f327f/)
[Failed :arrow_down:0.45% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7b7a6c2ff5c64c7aab7e4f38910b7d6e...01cfa1661c444ba0a1ed9f1ff691cec8/)
[Finished :arrow_down:0.22% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a8090f61e5464e149f9200bcd7161ee4...0e434b6c358342a3be2253a61c549839/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org