You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "yjhjstz (via GitHub)" <gi...@apache.org> on 2026/01/05 18:02:08 UTC
[PR] interconnect: increase UDP unack queue size and fix mem size unit [cloudberry]
yjhjstz opened a new pull request, #1520:
URL: https://github.com/apache/cloudberry/pull/1520
Increase MAX_QUEUE_SIZE from 64 to 128 to allow a larger unacknowledged packet window in UDP interconnect, reducing stalls under high-latency or bursty workloads.
Fix calculation of per-queue capacity in SetupUDPIFCInterconnect by properly converting gp_interconnect_mem_size from MB to bytes. Without this conversion, the derived send queue depth could be severely underestimated, leading to suboptimal throughput.
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] interconnect: increase UDP unack queue size and fix mem size unit [cloudberry]
Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it commented on code in PR #1520:
URL: https://github.com/apache/cloudberry/pull/1520#discussion_r2719886815
##########
contrib/udp2/ic_udp2.c:
##########
@@ -179,7 +179,7 @@ SetupInterconnectUDP2(EState *estate)
Gp_interconnect_queue_depth == 4 &&
Gp_interconnect_snd_queue_depth == 2)
{
- int32 perQueue = Gp_interconnect_mem_size /
+ int32 perQueue = ((int64)Gp_interconnect_mem_size * 1024 * 1024) /
Review Comment:
How about we change the variable name? This name is easily confused with Gp_max_packet_size, but the units are different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] interconnect: increase UDP unack queue size and fix mem size unit [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz closed pull request #1520: interconnect: increase UDP unack queue size and fix mem size unit
URL: https://github.com/apache/cloudberry/pull/1520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] interconnect: increase UDP unack queue size and fix mem size unit [cloudberry]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1520:
URL: https://github.com/apache/cloudberry/pull/1520#discussion_r2662378521
##########
contrib/interconnect/udp/ic_udpifc.c:
##########
@@ -3753,7 +3753,7 @@ SetupUDPIFCInterconnect(EState *estate)
Gp_interconnect_queue_depth == 4 &&
Gp_interconnect_snd_queue_depth == 2)
{
- int32 perQueue = Gp_interconnect_mem_size /
+ int32 perQueue = ((int64)Gp_interconnect_mem_size * 1024 * 1024) /
(Gp_max_packet_size * sliceNum);
Review Comment:
The denominator calculation `(Gp_max_packet_size * sliceNum)` can overflow when both operands are large. Since `Gp_max_packet_size` is an `int` (max 65507) and `sliceNum` is an `int32`, their multiplication is performed as integer arithmetic before being used in the division with `int64`. For example, if `Gp_max_packet_size = 65507` and `sliceNum = 40000`, the product (2,620,280,000) exceeds INT_MAX (2,147,483,647), causing integer overflow.
To prevent this, cast one of the operands in the denominator to `int64` before the multiplication, similar to how the numerator is handled.
```suggestion
((int64) Gp_max_packet_size * sliceNum);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] interconnect: increase UDP unack queue size and fix mem size unit [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1520:
URL: https://github.com/apache/cloudberry/pull/1520#discussion_r2722223348
##########
contrib/udp2/ic_udp2.c:
##########
@@ -179,7 +179,7 @@ SetupInterconnectUDP2(EState *estate)
Gp_interconnect_queue_depth == 4 &&
Gp_interconnect_snd_queue_depth == 2)
{
- int32 perQueue = Gp_interconnect_mem_size /
+ int32 perQueue = ((int64)Gp_interconnect_mem_size * 1024 * 1024) /
Review Comment:
related https://github.com/apache/cloudberry/pull/1540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] interconnect: increase UDP unack queue size and fix mem size unit [cloudberry]
Posted by "leborchuk (via GitHub)" <gi...@apache.org>.
leborchuk commented on code in PR #1520:
URL: https://github.com/apache/cloudberry/pull/1520#discussion_r2662849054
##########
contrib/interconnect/udp/ic_udpifc.c:
##########
@@ -3753,7 +3753,7 @@ SetupUDPIFCInterconnect(EState *estate)
Gp_interconnect_queue_depth == 4 &&
Gp_interconnect_snd_queue_depth == 2)
{
- int32 perQueue = Gp_interconnect_mem_size /
+ int32 perQueue = ((int64)Gp_interconnect_mem_size * 1024 * 1024) /
Review Comment:
The same logic also in udp2/ic_udp2.c, line 182.
Should we fix it in ic_udp2.c too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org