You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "jpappa200 (via GitHub)" <gi...@apache.org> on 2023/02/27 16:29:22 UTC
[GitHub] [trafficcontrol] jpappa200 opened a new pull request, #7366: T3c apply metadata
jpappa200 opened a new pull request, #7366:
URL: https://github.com/apache/trafficcontrol/pull/7366
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Right now the t3c-metadata.json file is updated every time t3c runs. Each run updates the timestamp field witch causes git to commit the change to the repo. Since t3c is running every minute in revalidate mode this is causing excessive commits to the repo and actual changes are being lost in the noise. This PR will remove the timestamp field, which reduces the amount of commits to the repo. The file itself still has the filesystem timestamp and we can also see the last change to the metadata file in git when it does change.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Control Cache Config (`t3c`, formerly ORT)
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Run t3c with no updates queued and verify that timestamp file has been removed. force a config file change, queue updates, run t3c in syncds mode, verify changes to t3c-metadata.json and config files have been committed. run t3c again without updates queued and verify no changes to metadata file.
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
Not a bug fix
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7366: T3c apply metadata
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7366:
URL: https://github.com/apache/trafficcontrol/pull/7366#issuecomment-1446654868
# [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7366](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e30e970) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/6839edd61a7c70c8403ab9b468c648a2d61a92ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6839edd) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head e30e970 differs from pull request most recent head 5a339d2. Consider uploading reports for the commit 5a339d2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #7366 +/- ##
============================================
+ Coverage 26.15% 26.16% +0.01%
Complexity 98 98
============================================
Files 392 648 +256
Lines 45649 76195 +30546
Branches 90 90
============================================
+ Hits 11938 19935 +7997
- Misses 32744 54421 +21677
- Partials 967 1839 +872
```
| Flag | Coverage Δ | |
|---|---|---|
| golib_unit | `53.16% <ø> (?)` | |
| grove_unit | `4.60% <ø> (?)` | |
| t3c_unit | `5.33% <ø> (?)` | |
| traffic_monitor_unit | `20.43% <ø> (?)` | |
| traffic_ops_unit | `19.70% <ø> (ø)` | |
| traffic_stats_unit | `10.41% <ø> (?)` | |
| unit_tests | `22.59% <ø> (+2.89%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cache-config/t3c-apply/t3c-apply.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2FjaGUtY29uZmlnL3QzYy1hcHBseS90M2MtYXBwbHkuZ28=) | `0.00% <ø> (ø)` | |
| [cache-config/t3cutil/t3cutil.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2FjaGUtY29uZmlnL3QzY3V0aWwvdDNjdXRpbC5nbw==) | `19.78% <ø> (ø)` | |
| [cache-config/t3c-generate/cfgfile/wrappers.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2FjaGUtY29uZmlnL3QzYy1nZW5lcmF0ZS9jZmdmaWxlL3dyYXBwZXJzLmdv) | `49.45% <0.00%> (-0.13%)` | :arrow_down: |
| [traffic\_monitor/threadsafe/dsstats.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19tb25pdG9yL3RocmVhZHNhZmUvZHNzdGF0cy5nbw==) | `0.00% <0.00%> (ø)` | |
| [traffic\_monitor/datareq/crconfighist.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19tb25pdG9yL2RhdGFyZXEvY3Jjb25maWdoaXN0Lmdv) | `0.00% <0.00%> (ø)` | |
| [grove/plugin/plugin.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JvdmUvcGx1Z2luL3BsdWdpbi5nbw==) | `5.55% <0.00%> (ø)` | |
| [lib/go-atscfg/cachedotconfig.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLWF0c2NmZy9jYWNoZWRvdGNvbmZpZy5nbw==) | `42.37% <0.00%> (ø)` | |
| [traffic\_monitor/tools/testto/testto.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19tb25pdG9yL3Rvb2xzL3Rlc3R0by90ZXN0dG8uZ28=) | `0.00% <0.00%> (ø)` | |
| [grove/memcache/memcache.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JvdmUvbWVtY2FjaGUvbWVtY2FjaGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [traffic\_monitor/tools/testcaches/testcaches.go](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19tb25pdG9yL3Rvb2xzL3Rlc3RjYWNoZXMvdGVzdGNhY2hlcy5nbw==) | `0.00% <0.00%> (ø)` | |
| ... and [249 more](https://codecov.io/gh/apache/trafficcontrol/pull/7366?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #7366: T3c apply metadata
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman merged PR #7366:
URL: https://github.com/apache/trafficcontrol/pull/7366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org