You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "yl09099 (via GitHub)" <gi...@apache.org> on 2023/12/05 08:20:47 UTC
[PR] Uniffle 960 5 [incubator-uniffle]
yl09099 opened a new pull request, #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347
### What changes were proposed in this pull request?
simplify dependency and correct the startup script.
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
Fix: #960
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
Needn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1840298727
What's this pr the relationship of https://github.com/apache/incubator-uniffle/pull/1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1849550734
> > Could you fix these two problems in this pr? @yl09099 [#1339 (comment)](https://github.com/apache/incubator-uniffle/pull/1339#issuecomment-1831538825)
>
> This has been modified.
It seems that one of them was be fixed. But we still must set the env `HADOOP_HOME`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#discussion_r1424804643
##########
bin/utils.sh:
##########
@@ -152,6 +152,11 @@ function is_port_in_use {
function load_rss_env {
set -o allexport
+ is_dashboard=1
+ if [ $# -eq 1 ]; then
+ is_dashboard=$1
+ fi
Review Comment:
Have no better idea. Follow your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on code in PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#discussion_r1423754893
##########
bin/utils.sh:
##########
@@ -152,6 +152,11 @@ function is_port_in_use {
function load_rss_env {
set -o allexport
+ is_dashboard=1
+ if [ $# -eq 1 ]; then
+ is_dashboard=$1
+ fi
Review Comment:
```suggestion
is_dashboard=0
if [ $# -eq 1 ]; then
is_dashboard=1
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1853581947
Thanks @yl09099 @xianjingfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1849530795
Could you fix these two problems in the pr? @yl09099
https://github.com/apache/incubator-uniffle/pull/1339#issuecomment-1831538825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on code in PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#discussion_r1423751610
##########
bin/utils.sh:
##########
@@ -172,7 +177,9 @@ function load_rss_env {
echo "No env JAVA_HOME."
exit 1
fi
- if [ -z "$HADOOP_HOME" ]; then
+ if [[ $is_dashboard -eq 0 || -z "$HADOOP_HOME" ]]; then
+ echo "Dashboard need not HADOOP_HOME."
+ elif [[ -z "$HADOOP_HOME" ]]; then
echo "No env HADOOP_HOME."
exit 1
fi
Review Comment:
```suggestion
if [[ -z "$HADOOP_HOME" ]]; then
if [[ $is_dashboard -eq 1 ]]; then
echo "Dashboard need not HADOOP_HOME."
else
echo "No env HADOOP_HOME."
exit 1
fi
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1849536730
> Could you fix these two problems in this pr? @yl09099 [#1339 (comment)](https://github.com/apache/incubator-uniffle/pull/1339#issuecomment-1831538825)
This has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on code in PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#discussion_r1423751610
##########
bin/utils.sh:
##########
@@ -172,7 +177,9 @@ function load_rss_env {
echo "No env JAVA_HOME."
exit 1
fi
- if [ -z "$HADOOP_HOME" ]; then
+ if [[ $is_dashboard -eq 0 || -z "$HADOOP_HOME" ]]; then
+ echo "Dashboard need not HADOOP_HOME."
+ elif [[ -z "$HADOOP_HOME" ]]; then
echo "No env HADOOP_HOME."
exit 1
fi
Review Comment:
```suggestion
if [[ -z "$HADOOP_HOME" ]]; then
if [[ $is_dashboard -eq 0 ]]; then
echo "Dashboard need not HADOOP_HOME."
else
echo "No env HADOOP_HOME."
exit 1
fi
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1849451686
@zuston @xianjingfeng @jerqi Modify the dashboard pom dependencies, modify the startup script to be independent of Hadoop, and separate the dashboard configuration file from the Coordinator configuration file so that it can be deployed independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1851256997
> > > > > Could you fix these two problems in this pr? @yl09099 [#1339 (comment)](https://github.com/apache/incubator-uniffle/pull/1339#issuecomment-1831538825)
> > > >
> > > >
> > > > This has been modified.
> > >
> > >
> > > It seems that one of them was fixed. But we still must set the env `HADOOP_HOME`, right?
> >
> >
> > I have deleted the HDFS configuration in start-dashboard and do not need to set HADOOP_HOME on dashboard.
>
> Is there anything problems with the following code?
>
> https://github.com/apache/incubator-uniffle/blob/ecbf2e79423505dd44bf54c612572c5c9da71175/bin/utils.sh#L175-L178
Learned, changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1849605314
> > > Could you fix these two problems in this pr? @yl09099 [#1339 (comment)](https://github.com/apache/incubator-uniffle/pull/1339#issuecomment-1831538825)
> >
> >
> > This has been modified.
>
> It seems that one of them was fixed. But we still must set the env `HADOOP_HOME`, right?
I have deleted the configurations related to start-dashboard and HDFS, and do not need to set HADOOP_HOME on the dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1849456230
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`ecbf2e7`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/ecbf2e79423505dd44bf54c612572c5c9da71175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.22% compared to head [(`0eb1ac8`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1347?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.37%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1347 +/- ##
============================================
+ Coverage 53.22% 53.37% +0.14%
+ Complexity 2715 2182 -533
============================================
Files 418 341 -77
Lines 23932 15379 -8553
Branches 2043 1426 -617
============================================
- Hits 12738 8208 -4530
+ Misses 10408 6705 -3703
+ Partials 786 466 -320
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1347?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1840387581
> #1326
Some fixes based on PR #1326.I'm making changes after the merger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1840374486
> What's this pr the relationship of #1326
Same PR. I'm changing it after the merger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1849623077
> > > > Could you fix these two problems in this pr? @yl09099 [#1339 (comment)](https://github.com/apache/incubator-uniffle/pull/1339#issuecomment-1831538825)
> > >
> > >
> > > This has been modified.
> >
> >
> > It seems that one of them was fixed. But we still must set the env `HADOOP_HOME`, right?
>
> I have deleted the HDFS configuration in start-dashboard and do not need to set HADOOP_HOME on dashboard.
Is there anything problems with the following code?
https://github.com/apache/incubator-uniffle/blob/ecbf2e79423505dd44bf54c612572c5c9da71175/bin/utils.sh#L175-L178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#issuecomment-1849610498
> > > Could you fix these two problems in this pr? @yl09099 [#1339 (comment)](https://github.com/apache/incubator-uniffle/pull/1339#issuecomment-1831538825)
> >
> >
> > This has been modified.
>
> It seems that one of them was fixed. But we still must set the env `HADOOP_HOME`, right?
I have deleted the HDFS configuration in start-dashboard and do not need to set HADOOP_HOME on dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#960] fix(dashboard): simplify dependency and correct the startup script [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on code in PR #1347:
URL: https://github.com/apache/incubator-uniffle/pull/1347#discussion_r1423756811
##########
bin/utils.sh:
##########
@@ -152,6 +152,11 @@ function is_port_in_use {
function load_rss_env {
set -o allexport
+ is_dashboard=1
+ if [ $# -eq 1 ]; then
+ is_dashboard=$1
+ fi
Review Comment:
@zuston @jerqi Do you have any idea about this part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org