You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by 郑扬勇 <ya...@qq.com> on 2018/05/07 08:48:59 UTC
[Discussion]Java Chassis Support Gracefully Shutdown
Hi, All:
We did not implement gracefully shutdown yet:
// 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
// 1. 去注册实例信息
// TODO 服务优雅退出
if (applicationContext instanceof AbstractApplicationContext) {
((AbstractApplicationContext) applicationContext).registerShutdownHook();
}
And had got an issue : https://github.com/apache/incubator-servicecomb-java-chassis/issues/685 from user.
So i think it's time we must do it and remove this TODO ?
Best Regards!
YangYongZheng
Re: [Discussion]Java Chassis Support Gracefully Shutdown
Posted by Zen Lin <ze...@gmail.com>.
Hi Zhengyangyong,
You are a sharpshooter, thanks.
Hi Yangbo,
Yeah, agree with you, thanks.
Best Regards,
---
Zen Lin
zenlintechnofreak@gmail.com
Focused on Micro Service and Apache ServiceComb
2018-05-07 17:45 GMT+08:00 郑扬勇 <ya...@qq.com>:
> Done! JIRA link : https://issues.apache.org/jira/browse/SCB-548
>
> Best Regards!
> YangYongZheng
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "willem.jiang"<wi...@gmail.com>;
> 发送时间: 2018年5月7日(星期一) 下午5:21
> 收件人: "dev"<de...@servicecomb.apache.org>;
>
> 主题: Re: [Discussion]Java Chassis Support Gracefully Shutdown
>
>
>
> Yeah, Let's put it into our 1.0.0-m2 release plan.
>
> Yangyong, do you mind create a JIRA for it?
> We can keep track it in our release plan.
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
> http://jnn.iteye.com (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <ya...@qq.com> wrote:
>
> > Hi, All:
> > We did not implement gracefully shutdown yet:
> >
> > // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> > // 1. 去注册实例信息
> > // TODO 服务优雅退出
> > if (applicationContext instanceof AbstractApplicationContext) {
> > ((AbstractApplicationContext) applicationContext).
> > registerShutdownHook();
> > }
> >
> > And had got an issue : https://github.com/apache/
> > incubator-servicecomb-java-chassis/issues/685 from user.
> > So i think it's time we must do it and remove this TODO ?
> >
> > Best Regards!
> > YangYongZheng
>
回复： [Discussion]Java Chassis Support Gracefully Shutdown
Posted by 郑扬勇 <ya...@qq.com>.
Done! JIRA link : https://issues.apache.org/jira/browse/SCB-548
Best Regards!
YangYongZheng
------------------ 原始邮件 ------------------
发件人: "willem.jiang"<wi...@gmail.com>;
发送时间: 2018年5月7日(星期一) 下午5:21
收件人: "dev"<de...@servicecomb.apache.org>;
主题: Re: [Discussion]Java Chassis Support Gracefully Shutdown
Yeah, Let's put it into our 1.0.0-m2 release plan.
Yangyong, do you mind create a JIRA for it?
We can keep track it in our release plan.
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <ya...@qq.com> wrote:
> Hi, All:
> We did not implement gracefully shutdown yet:
>
> // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> // 1. 去注册实例信息
> // TODO 服务优雅退出
> if (applicationContext instanceof AbstractApplicationContext) {
> ((AbstractApplicationContext) applicationContext).
> registerShutdownHook();
> }
>
> And had got an issue : https://github.com/apache/
> incubator-servicecomb-java-chassis/issues/685 from user.
> So i think it's time we must do it and remove this TODO ?
>
> Best Regards!
> YangYongZheng
Re: [Discussion]Java Chassis Support Gracefully Shutdown
Posted by Willem Jiang <wi...@gmail.com>.
Normally, we just keep on eye on the outstanding issues which we need to
finish in this release by go through the JIRA.
As we have the fix version on task, it could be easy for us to pick them up
and find out their status.
If there are any other feature or bug fix need to be finished, we'd better
figure them out in these two weeks.
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Mon, May 7, 2018 at 5:42 PM, Yang Bo <oa...@gmail.com> wrote:
> Yes, I'll send an email of all the status of ongoing issues by tomorrow. We
> can discuss this then.
>
> On Mon, May 7, 2018 at 5:34 PM, Zen Lin <ze...@gmail.com>
> wrote:
>
> > Hi YanBo,
> >
> > I think which release version can conclude the graceful shutdown is just
> > another topic,
> > but task about support graceful shutdown function in ServiceComb can be
> > start from now.
> >
> > Best Regards,
> > ---
> > Zen Lin
> > zenlintechnofreak@gmail.com
> > Focused on Micro Service and Apache ServiceComb
> >
> > 2018-05-07 17:30 GMT+08:00 Yang Bo <oa...@gmail.com>:
> >
> > > Do we have enough time to put this into 1.0.0-m2? I think we should
> > release
> > > m2 in early June.
> > >
> > > On Mon, May 7, 2018 at 5:27 PM, Zen Lin <ze...@gmail.com>
> > > wrote:
> > >
> > > > +1
> > > > I think it will be very useful to the users , and users like Fujian
> > > Mobile
> > > > and Chinese People's Insurance also have repeatedly requested.
> > > >
> > > > Best Regards,
> > > > ---
> > > > Zen Lin
> > > > zenlintechnofreak@gmail.com
> > > > Focused on Micro Service and Apache ServiceComb
> > > >
> > > > 2018-05-07 17:21 GMT+08:00 Willem Jiang <wi...@gmail.com>:
> > > >
> > > > > Yeah, Let's put it into our 1.0.0-m2 release plan.
> > > > >
> > > > > Yangyong, do you mind create a JIRA for it?
> > > > > We can keep track it in our release plan.
> > > > >
> > > > >
> > > > > Willem Jiang
> > > > >
> > > > > Blog: http://willemjiang.blogspot.com (English)
> > > > > http://jnn.iteye.com (Chinese)
> > > > > Twitter: willemjiang
> > > > > Weibo: 姜宁willem
> > > > >
> > > > > On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <ya...@qq.com> wrote:
> > > > >
> > > > > > Hi, All:
> > > > > > We did not implement gracefully shutdown yet:
> > > > > >
> > > > > > // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> > > > > > // 1. 去注册实例信息
> > > > > > // TODO 服务优雅退出
> > > > > > if (applicationContext instanceof
> > > > AbstractApplicationContext) {
> > > > > > ((AbstractApplicationContext) applicationContext).
> > > > > > registerShutdownHook();
> > > > > > }
> > > > > >
> > > > > > And had got an issue : https://github.com/apache/
> > > > > > incubator-servicecomb-java-chassis/issues/685 from user.
> > > > > > So i think it's time we must do it and remove this TODO ?
> > > > > >
> > > > > > Best Regards!
> > > > > > YangYongZheng
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Best Regards,
> > > Yang.
> > >
> >
>
>
>
> --
> Best Regards,
> Yang.
>
Re: [Discussion]Java Chassis Support Gracefully Shutdown
Posted by Yang Bo <oa...@gmail.com>.
Yes, I'll send an email of all the status of ongoing issues by tomorrow. We
can discuss this then.
On Mon, May 7, 2018 at 5:34 PM, Zen Lin <ze...@gmail.com> wrote:
> Hi YanBo,
>
> I think which release version can conclude the graceful shutdown is just
> another topic,
> but task about support graceful shutdown function in ServiceComb can be
> start from now.
>
> Best Regards,
> ---
> Zen Lin
> zenlintechnofreak@gmail.com
> Focused on Micro Service and Apache ServiceComb
>
> 2018-05-07 17:30 GMT+08:00 Yang Bo <oa...@gmail.com>:
>
> > Do we have enough time to put this into 1.0.0-m2? I think we should
> release
> > m2 in early June.
> >
> > On Mon, May 7, 2018 at 5:27 PM, Zen Lin <ze...@gmail.com>
> > wrote:
> >
> > > +1
> > > I think it will be very useful to the users , and users like Fujian
> > Mobile
> > > and Chinese People's Insurance also have repeatedly requested.
> > >
> > > Best Regards,
> > > ---
> > > Zen Lin
> > > zenlintechnofreak@gmail.com
> > > Focused on Micro Service and Apache ServiceComb
> > >
> > > 2018-05-07 17:21 GMT+08:00 Willem Jiang <wi...@gmail.com>:
> > >
> > > > Yeah, Let's put it into our 1.0.0-m2 release plan.
> > > >
> > > > Yangyong, do you mind create a JIRA for it?
> > > > We can keep track it in our release plan.
> > > >
> > > >
> > > > Willem Jiang
> > > >
> > > > Blog: http://willemjiang.blogspot.com (English)
> > > > http://jnn.iteye.com (Chinese)
> > > > Twitter: willemjiang
> > > > Weibo: 姜宁willem
> > > >
> > > > On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <ya...@qq.com> wrote:
> > > >
> > > > > Hi, All:
> > > > > We did not implement gracefully shutdown yet:
> > > > >
> > > > > // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> > > > > // 1. 去注册实例信息
> > > > > // TODO 服务优雅退出
> > > > > if (applicationContext instanceof
> > > AbstractApplicationContext) {
> > > > > ((AbstractApplicationContext) applicationContext).
> > > > > registerShutdownHook();
> > > > > }
> > > > >
> > > > > And had got an issue : https://github.com/apache/
> > > > > incubator-servicecomb-java-chassis/issues/685 from user.
> > > > > So i think it's time we must do it and remove this TODO ?
> > > > >
> > > > > Best Regards!
> > > > > YangYongZheng
> > > >
> > >
> >
> >
> >
> > --
> > Best Regards,
> > Yang.
> >
>
--
Best Regards,
Yang.
Re: [Discussion]Java Chassis Support Gracefully Shutdown
Posted by Zen Lin <ze...@gmail.com>.
Hi YanBo,
I think which release version can conclude the graceful shutdown is just
another topic,
but task about support graceful shutdown function in ServiceComb can be
start from now.
Best Regards,
---
Zen Lin
zenlintechnofreak@gmail.com
Focused on Micro Service and Apache ServiceComb
2018-05-07 17:30 GMT+08:00 Yang Bo <oa...@gmail.com>:
> Do we have enough time to put this into 1.0.0-m2? I think we should release
> m2 in early June.
>
> On Mon, May 7, 2018 at 5:27 PM, Zen Lin <ze...@gmail.com>
> wrote:
>
> > +1
> > I think it will be very useful to the users , and users like Fujian
> Mobile
> > and Chinese People's Insurance also have repeatedly requested.
> >
> > Best Regards,
> > ---
> > Zen Lin
> > zenlintechnofreak@gmail.com
> > Focused on Micro Service and Apache ServiceComb
> >
> > 2018-05-07 17:21 GMT+08:00 Willem Jiang <wi...@gmail.com>:
> >
> > > Yeah, Let's put it into our 1.0.0-m2 release plan.
> > >
> > > Yangyong, do you mind create a JIRA for it?
> > > We can keep track it in our release plan.
> > >
> > >
> > > Willem Jiang
> > >
> > > Blog: http://willemjiang.blogspot.com (English)
> > > http://jnn.iteye.com (Chinese)
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <ya...@qq.com> wrote:
> > >
> > > > Hi, All:
> > > > We did not implement gracefully shutdown yet:
> > > >
> > > > // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> > > > // 1. 去注册实例信息
> > > > // TODO 服务优雅退出
> > > > if (applicationContext instanceof
> > AbstractApplicationContext) {
> > > > ((AbstractApplicationContext) applicationContext).
> > > > registerShutdownHook();
> > > > }
> > > >
> > > > And had got an issue : https://github.com/apache/
> > > > incubator-servicecomb-java-chassis/issues/685 from user.
> > > > So i think it's time we must do it and remove this TODO ?
> > > >
> > > > Best Regards!
> > > > YangYongZheng
> > >
> >
>
>
>
> --
> Best Regards,
> Yang.
>
Re: [Discussion]Java Chassis Support Gracefully Shutdown
Posted by Yang Bo <oa...@gmail.com>.
Do we have enough time to put this into 1.0.0-m2? I think we should release
m2 in early June.
On Mon, May 7, 2018 at 5:27 PM, Zen Lin <ze...@gmail.com> wrote:
> +1
> I think it will be very useful to the users , and users like Fujian Mobile
> and Chinese People's Insurance also have repeatedly requested.
>
> Best Regards,
> ---
> Zen Lin
> zenlintechnofreak@gmail.com
> Focused on Micro Service and Apache ServiceComb
>
> 2018-05-07 17:21 GMT+08:00 Willem Jiang <wi...@gmail.com>:
>
> > Yeah, Let's put it into our 1.0.0-m2 release plan.
> >
> > Yangyong, do you mind create a JIRA for it?
> > We can keep track it in our release plan.
> >
> >
> > Willem Jiang
> >
> > Blog: http://willemjiang.blogspot.com (English)
> > http://jnn.iteye.com (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <ya...@qq.com> wrote:
> >
> > > Hi, All:
> > > We did not implement gracefully shutdown yet:
> > >
> > > // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> > > // 1. 去注册实例信息
> > > // TODO 服务优雅退出
> > > if (applicationContext instanceof
> AbstractApplicationContext) {
> > > ((AbstractApplicationContext) applicationContext).
> > > registerShutdownHook();
> > > }
> > >
> > > And had got an issue : https://github.com/apache/
> > > incubator-servicecomb-java-chassis/issues/685 from user.
> > > So i think it's time we must do it and remove this TODO ?
> > >
> > > Best Regards!
> > > YangYongZheng
> >
>
--
Best Regards,
Yang.
Re: [Discussion]Java Chassis Support Gracefully Shutdown
Posted by Zen Lin <ze...@gmail.com>.
+1
I think it will be very useful to the users , and users like Fujian Mobile
and Chinese People's Insurance also have repeatedly requested.
Best Regards,
---
Zen Lin
zenlintechnofreak@gmail.com
Focused on Micro Service and Apache ServiceComb
2018-05-07 17:21 GMT+08:00 Willem Jiang <wi...@gmail.com>:
> Yeah, Let's put it into our 1.0.0-m2 release plan.
>
> Yangyong, do you mind create a JIRA for it?
> We can keep track it in our release plan.
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
> http://jnn.iteye.com (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <ya...@qq.com> wrote:
>
> > Hi, All:
> > We did not implement gracefully shutdown yet:
> >
> > // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> > // 1. 去注册实例信息
> > // TODO 服务优雅退出
> > if (applicationContext instanceof AbstractApplicationContext) {
> > ((AbstractApplicationContext) applicationContext).
> > registerShutdownHook();
> > }
> >
> > And had got an issue : https://github.com/apache/
> > incubator-servicecomb-java-chassis/issues/685 from user.
> > So i think it's time we must do it and remove this TODO ?
> >
> > Best Regards!
> > YangYongZheng
>
Re: [Discussion]Java Chassis Support Gracefully Shutdown
Posted by Willem Jiang <wi...@gmail.com>.
Yeah, Let's put it into our 1.0.0-m2 release plan.
Yangyong, do you mind create a JIRA for it?
We can keep track it in our release plan.
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <ya...@qq.com> wrote:
> Hi, All:
> We did not implement gracefully shutdown yet:
>
> // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> // 1. 去注册实例信息
> // TODO 服务优雅退出
> if (applicationContext instanceof AbstractApplicationContext) {
> ((AbstractApplicationContext) applicationContext).
> registerShutdownHook();
> }
>
> And had got an issue : https://github.com/apache/
> incubator-servicecomb-java-chassis/issues/685 from user.
> So i think it's time we must do it and remove this TODO ?
>
> Best Regards!
> YangYongZheng