You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/19 10:50:59 UTC

[GitHub] [cloudstack] j-porsche opened a new pull request #5217: Possiblity to choose between docker and podman from the command line

j-porsche opened a new pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217


   ### Description
   
   This PR adds the possibility to choose between docker and podman to run the docker.sh script from the command line. From now on you are able to add a flag after the script (-p) to run the script with podman. @weizhouapache For backwardwards compatibility, docker is used by default.
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] j-porsche commented on pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
j-porsche commented on pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217#issuecomment-882448438


   @svenvogel @utchoang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217#discussion_r689423444



##########
File path: ui/docker.sh
##########
@@ -29,5 +29,19 @@ DATE="$(date --iso-8601=seconds)"
 LABEL_DATE="--label \"org.opencontainers.image.created=${DATE}\""
 GIT_REV="$(git rev-parse HEAD)"
 LABEL_GIT_REV="--label \"org.opencontainers.image.revision=${GIT_REV}\""
-
+USE_PODMAN=0
+USE_DOCKER=0
+OPTIONS='pd'
+while getopts $OPTIONS OPTION
+do
+        case "$OPTION" in
+                p)USE_PODMAN=1;;
+                d)USE_DOCKER=1;;
+                *)echo "Please choose between -p for podman or -d for docker.";;

Review comment:
       @j-porsche `exit` at  line 40 ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] j-porsche commented on pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
j-porsche commented on pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217#issuecomment-899417004


   @weizhouapache I have updated the file. Could You please look at it again. Thank You :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] j-porsche commented on pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
j-porsche commented on pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217#issuecomment-882448983


   This PR was already made but with some mistakes. From now on I will manage this PR. The old one was: Add selection for podman/docker #5141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] j-porsche commented on pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
j-porsche commented on pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217#issuecomment-885632392


   @weizhouapache May You take a look at it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] j-porsche commented on pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
j-porsche commented on pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217#issuecomment-882448438






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] j-porsche commented on pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
j-porsche commented on pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217#issuecomment-899374235


   @weizhouapache Could You take a look at it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] j-porsche commented on a change in pull request #5217: Possiblity to choose between docker and podman from the command line

Posted by GitBox <gi...@apache.org>.
j-porsche commented on a change in pull request #5217:
URL: https://github.com/apache/cloudstack/pull/5217#discussion_r689427779



##########
File path: ui/docker.sh
##########
@@ -29,5 +29,19 @@ DATE="$(date --iso-8601=seconds)"
 LABEL_DATE="--label \"org.opencontainers.image.created=${DATE}\""
 GIT_REV="$(git rev-parse HEAD)"
 LABEL_GIT_REV="--label \"org.opencontainers.image.revision=${GIT_REV}\""
-
+USE_PODMAN=0
+USE_DOCKER=0
+OPTIONS='pd'
+while getopts $OPTIONS OPTION
+do
+        case "$OPTION" in
+                p)USE_PODMAN=1;;
+                d)USE_DOCKER=1;;
+                *)echo "Please choose between -p for podman or -d for docker.";;

Review comment:
       @weizhouapache Yeah. Good point. I'll add this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org