You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/22 17:56:27 UTC

[GitHub] [superset] robdiciuccio commented on a change in pull request #14274: chore: Add Redis password option to helm chart

robdiciuccio commented on a change in pull request #14274:
URL: https://github.com/apache/superset/pull/14274#discussion_r618622777



##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -63,8 +63,8 @@ CACHE_CONFIG = {
       'CACHE_KEY_PREFIX': 'superset_',
       'CACHE_REDIS_HOST': env('REDIS_HOST'),
       'CACHE_REDIS_PORT': env('REDIS_PORT'),
-      'CACHE_REDIS_DB': 1,
-      'CACHE_REDIS_URL': f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/1"

Review comment:
       Not if the other options are preset (it's essentially duplicating the above). Tested this config locally, and works without `CACHE_REDIS_URL`.

##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -63,8 +63,8 @@ CACHE_CONFIG = {
       'CACHE_KEY_PREFIX': 'superset_',
       'CACHE_REDIS_HOST': env('REDIS_HOST'),
       'CACHE_REDIS_PORT': env('REDIS_PORT'),
-      'CACHE_REDIS_DB': 1,
-      'CACHE_REDIS_URL': f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/1"

Review comment:
       Not if the other options are present (it's essentially duplicating the above). Tested this config locally, and works without `CACHE_REDIS_URL`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org