You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/11/05 09:49:27 UTC
Review Request 27610: SQOOP-1661: Sqoop2: Intermediate data format
text null handling
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27610/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1661
https://issues.apache.org/jira/browse/SQOOP-1661
Repository: sqoop-sqoop2
Description
-------
commit b144146a8ef879813018bee6e7da844991d61298
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Wed Nov 5 00:46:12 2014 -0800
SQOOP-1661: Sqoop2: Intermediate data format text null handling
:100644 100644 7eb1d8d... f3e5887... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
:100644 100644 74f2e07... 139b1b4... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
Diffs
-----
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 7eb1d8d
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 74f2e07
Diff: https://reviews.apache.org/r/27610/diff/
Testing
-------
mvn test
Thanks,
Abraham Elmahrek
Re: Review Request 27610: SQOOP-1661: Sqoop2: Intermediate data
format text null handling
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27610/#review59956
-----------------------------------------------------------
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
<https://reviews.apache.org/r/27610/#comment101261>
Based on the proposal the null string should be encoded with "NULL" (capital):
https://cwiki.apache.org/confluence/display/SQOOP/Sqoop2+Intermediate+representation
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
<https://reviews.apache.org/r/27610/#comment101262>
I think that "null" should not be in quotes here because then we don't know whether the value was null or whether the "null" is a valid string. It seems that the proposal is stating that NULL value should be encoded with just NULL (capital and without quotes), something like:
10,34,NULL,'random data',...
https://cwiki.apache.org/confluence/display/SQOOP/Sqoop2+Intermediate+representation
- Jarek Cecho
On Nov. 5, 2014, 8:49 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27610/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 8:49 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1661
> https://issues.apache.org/jira/browse/SQOOP-1661
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b144146a8ef879813018bee6e7da844991d61298
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Wed Nov 5 00:46:12 2014 -0800
>
> SQOOP-1661: Sqoop2: Intermediate data format text null handling
>
> :100644 100644 7eb1d8d... f3e5887... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> :100644 100644 74f2e07... 139b1b4... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
>
>
> Diffs
> -----
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 7eb1d8d
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 74f2e07
>
> Diff: https://reviews.apache.org/r/27610/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 27610: SQOOP-1661: Sqoop2: Intermediate data
format text null handling
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27610/#review60043
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Nov. 5, 2014, 9:35 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27610/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 9:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1661
> https://issues.apache.org/jira/browse/SQOOP-1661
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b144146a8ef879813018bee6e7da844991d61298
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Wed Nov 5 00:46:12 2014 -0800
>
> SQOOP-1661: Sqoop2: Intermediate data format text null handling
>
> :100644 100644 7eb1d8d... f3e5887... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> :100644 100644 74f2e07... 139b1b4... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
>
>
> Diffs
> -----
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 4e0ecee
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 291fef2
>
> Diff: https://reviews.apache.org/r/27610/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 27610: SQOOP-1661: Sqoop2: Intermediate data
format text null handling
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27610/
-----------------------------------------------------------
(Updated Nov. 5, 2014, 9:35 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1661
https://issues.apache.org/jira/browse/SQOOP-1661
Repository: sqoop-sqoop2
Description
-------
commit b144146a8ef879813018bee6e7da844991d61298
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Wed Nov 5 00:46:12 2014 -0800
SQOOP-1661: Sqoop2: Intermediate data format text null handling
:100644 100644 7eb1d8d... f3e5887... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
:100644 100644 74f2e07... 139b1b4... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
Diffs (updated)
-----
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 4e0ecee
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 291fef2
Diff: https://reviews.apache.org/r/27610/diff/
Testing
-------
mvn test
Thanks,
Abraham Elmahrek