You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by Jonathan Gallimore <jo...@gmail.com> on 2018/04/15 20:28:12 UTC
Re: [DISCUSS] switching TomEE8 to master
Hi,
This discussion originated on the TomEE dev@ list, but I think it is more
appropriate that it continue here. Effectively I'm looking at trying to
provide a 1.0.1 version of Johnzon that is at the the same API level as
1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
release.
I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
discussion. I'll attempt to cross-reference this back to the JIRAs fixed
over the next couple of days, but I'd welcome any feedback.
Many thanks
Jon
On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
jonathan.gallimore@gmail.com> wrote:
> Happy to try that. I'll give that a go this evening. I misunderstood your
> proposal, but it makes sense now.
>
> Cheers
>
> Jo
>
> On 1 Apr 2018 17:41, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
>
> What about my proposal? Take johnzon master, copy it over 1.0.x and
> downgrade apis? It is probably the safest and shouldnt be long to make
> work. Can help next week if needed.
>
> Le 1 avr. 2018 17:06, "Jonathan Gallimore" <jo...@gmail.com>
> a
> écrit :
>
> > Agreed. I'll start working on the list of fixes tonight.
> >
> > Jon
> >
> > On Sun, 1 Apr 2018, 16:02 Mark Struberg, <st...@yahoo.de.invalid>
> > wrote:
> >
> > > Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
> Java8
> > > as min version).
> > >
> > > And I'd also happily volunteer to release Johnzon-1.0.1.
> > >
> > > BUT, first we need to check which Johnzon bugfixes are necessary to
> > > backport!
> > > Then let's create tickets for that version and solve them.
> > >
> > > LieGrue,
> > > strub
> > >
> > >
> > > > Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> > > jonathan.gallimore@gmail.com>:
> > > >
> > > > I think getting TomEE 8 out is obviously is preferred option. I would
> > > still
> > > > like to maintain TomEE 7 for those that want it. I'd be happy to go
> > > through
> > > > JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> > >
> > >
> >
>
>
>
Re: [DISCUSS] switching TomEE8 to master
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
Will review and apply later.
LieGrue,
Strub
> Am 16.04.2018 um 07:16 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>
> (Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
> member of the community review it since, as you mentionned, idea was coming
> from me but happy to apply it after.
>
> Le 15 avr. 2018 22:28, "Jonathan Gallimore" <jo...@gmail.com>
> a écrit :
>
>> Hi,
>>
>> This discussion originated on the TomEE dev@ list, but I think it is more
>> appropriate that it continue here. Effectively I'm looking at trying to
>> provide a 1.0.1 version of Johnzon that is at the the same API level as
>> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
>> release.
>>
>> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
>> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
>> over the next couple of days, but I'd welcome any feedback.
>>
>> Many thanks
>>
>> Jon
>>
>> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
>> jonathan.gallimore@gmail.com> wrote:
>>
>>> Happy to try that. I'll give that a go this evening. I misunderstood your
>>> proposal, but it makes sense now.
>>>
>>> Cheers
>>>
>>> Jo
>>>
>>> On 1 Apr 2018 17:41, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
>>>
>>> What about my proposal? Take johnzon master, copy it over 1.0.x and
>>> downgrade apis? It is probably the safest and shouldnt be long to make
>>> work. Can help next week if needed.
>>>
>>> Le 1 avr. 2018 17:06, "Jonathan Gallimore" <jonathan.gallimore@gmail.com
>>>
>>> a
>>> écrit :
>>>
>>>> Agreed. I'll start working on the list of fixes tonight.
>>>>
>>>> Jon
>>>>
>>>> On Sun, 1 Apr 2018, 16:02 Mark Struberg, <st...@yahoo.de.invalid>
>>>> wrote:
>>>>
>>>>> Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
>>> Java8
>>>>> as min version).
>>>>>
>>>>> And I'd also happily volunteer to release Johnzon-1.0.1.
>>>>>
>>>>> BUT, first we need to check which Johnzon bugfixes are necessary to
>>>>> backport!
>>>>> Then let's create tickets for that version and solve them.
>>>>>
>>>>> LieGrue,
>>>>> strub
>>>>>
>>>>>
>>>>>> Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
>>>>> jonathan.gallimore@gmail.com>:
>>>>>>
>>>>>> I think getting TomEE 8 out is obviously is preferred option. I
>> would
>>>>> still
>>>>>> like to maintain TomEE 7 for those that want it. I'd be happy to go
>>>>> through
>>>>>> JIRA, and backport fixes as necessary for Johnzon 1.0.x.
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>
Re: [DISCUSS] switching TomEE8 to master
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
Will review and apply later.
LieGrue,
Strub
> Am 16.04.2018 um 07:16 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>
> (Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
> member of the community review it since, as you mentionned, idea was coming
> from me but happy to apply it after.
>
> Le 15 avr. 2018 22:28, "Jonathan Gallimore" <jo...@gmail.com>
> a écrit :
>
>> Hi,
>>
>> This discussion originated on the TomEE dev@ list, but I think it is more
>> appropriate that it continue here. Effectively I'm looking at trying to
>> provide a 1.0.1 version of Johnzon that is at the the same API level as
>> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
>> release.
>>
>> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
>> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
>> over the next couple of days, but I'd welcome any feedback.
>>
>> Many thanks
>>
>> Jon
>>
>> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
>> jonathan.gallimore@gmail.com> wrote:
>>
>>> Happy to try that. I'll give that a go this evening. I misunderstood your
>>> proposal, but it makes sense now.
>>>
>>> Cheers
>>>
>>> Jo
>>>
>>> On 1 Apr 2018 17:41, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
>>>
>>> What about my proposal? Take johnzon master, copy it over 1.0.x and
>>> downgrade apis? It is probably the safest and shouldnt be long to make
>>> work. Can help next week if needed.
>>>
>>> Le 1 avr. 2018 17:06, "Jonathan Gallimore" <jonathan.gallimore@gmail.com
>>>
>>> a
>>> écrit :
>>>
>>>> Agreed. I'll start working on the list of fixes tonight.
>>>>
>>>> Jon
>>>>
>>>> On Sun, 1 Apr 2018, 16:02 Mark Struberg, <st...@yahoo.de.invalid>
>>>> wrote:
>>>>
>>>>> Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
>>> Java8
>>>>> as min version).
>>>>>
>>>>> And I'd also happily volunteer to release Johnzon-1.0.1.
>>>>>
>>>>> BUT, first we need to check which Johnzon bugfixes are necessary to
>>>>> backport!
>>>>> Then let's create tickets for that version and solve them.
>>>>>
>>>>> LieGrue,
>>>>> strub
>>>>>
>>>>>
>>>>>> Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
>>>>> jonathan.gallimore@gmail.com>:
>>>>>>
>>>>>> I think getting TomEE 8 out is obviously is preferred option. I
>> would
>>>>> still
>>>>>> like to maintain TomEE 7 for those that want it. I'd be happy to go
>>>>> through
>>>>>> JIRA, and backport fixes as necessary for Johnzon 1.0.x.
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>
Re: [DISCUSS] switching TomEE8 to master
Posted by Romain Manni-Bucau <rm...@gmail.com>.
(Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
member of the community review it since, as you mentionned, idea was coming
from me but happy to apply it after.
Le 15 avr. 2018 22:28, "Jonathan Gallimore" <jo...@gmail.com>
a écrit :
> Hi,
>
> This discussion originated on the TomEE dev@ list, but I think it is more
> appropriate that it continue here. Effectively I'm looking at trying to
> provide a 1.0.1 version of Johnzon that is at the the same API level as
> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
> release.
>
> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
> over the next couple of days, but I'd welcome any feedback.
>
> Many thanks
>
> Jon
>
> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
> jonathan.gallimore@gmail.com> wrote:
>
> > Happy to try that. I'll give that a go this evening. I misunderstood your
> > proposal, but it makes sense now.
> >
> > Cheers
> >
> > Jo
> >
> > On 1 Apr 2018 17:41, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
> >
> > What about my proposal? Take johnzon master, copy it over 1.0.x and
> > downgrade apis? It is probably the safest and shouldnt be long to make
> > work. Can help next week if needed.
> >
> > Le 1 avr. 2018 17:06, "Jonathan Gallimore" <jonathan.gallimore@gmail.com
> >
> > a
> > écrit :
> >
> > > Agreed. I'll start working on the list of fixes tonight.
> > >
> > > Jon
> > >
> > > On Sun, 1 Apr 2018, 16:02 Mark Struberg, <st...@yahoo.de.invalid>
> > > wrote:
> > >
> > > > Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
> > Java8
> > > > as min version).
> > > >
> > > > And I'd also happily volunteer to release Johnzon-1.0.1.
> > > >
> > > > BUT, first we need to check which Johnzon bugfixes are necessary to
> > > > backport!
> > > > Then let's create tickets for that version and solve them.
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > > > Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> > > > jonathan.gallimore@gmail.com>:
> > > > >
> > > > > I think getting TomEE 8 out is obviously is preferred option. I
> would
> > > > still
> > > > > like to maintain TomEE 7 for those that want it. I'd be happy to go
> > > > through
> > > > > JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> > > >
> > > >
> > >
> >
> >
> >
>
Re: [DISCUSS] switching TomEE8 to master
Posted by Romain Manni-Bucau <rm...@gmail.com>.
(Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
member of the community review it since, as you mentionned, idea was coming
from me but happy to apply it after.
Le 15 avr. 2018 22:28, "Jonathan Gallimore" <jo...@gmail.com>
a écrit :
> Hi,
>
> This discussion originated on the TomEE dev@ list, but I think it is more
> appropriate that it continue here. Effectively I'm looking at trying to
> provide a 1.0.1 version of Johnzon that is at the the same API level as
> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
> release.
>
> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
> over the next couple of days, but I'd welcome any feedback.
>
> Many thanks
>
> Jon
>
> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
> jonathan.gallimore@gmail.com> wrote:
>
> > Happy to try that. I'll give that a go this evening. I misunderstood your
> > proposal, but it makes sense now.
> >
> > Cheers
> >
> > Jo
> >
> > On 1 Apr 2018 17:41, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
> >
> > What about my proposal? Take johnzon master, copy it over 1.0.x and
> > downgrade apis? It is probably the safest and shouldnt be long to make
> > work. Can help next week if needed.
> >
> > Le 1 avr. 2018 17:06, "Jonathan Gallimore" <jonathan.gallimore@gmail.com
> >
> > a
> > écrit :
> >
> > > Agreed. I'll start working on the list of fixes tonight.
> > >
> > > Jon
> > >
> > > On Sun, 1 Apr 2018, 16:02 Mark Struberg, <st...@yahoo.de.invalid>
> > > wrote:
> > >
> > > > Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
> > Java8
> > > > as min version).
> > > >
> > > > And I'd also happily volunteer to release Johnzon-1.0.1.
> > > >
> > > > BUT, first we need to check which Johnzon bugfixes are necessary to
> > > > backport!
> > > > Then let's create tickets for that version and solve them.
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > > > Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> > > > jonathan.gallimore@gmail.com>:
> > > > >
> > > > > I think getting TomEE 8 out is obviously is preferred option. I
> would
> > > > still
> > > > > like to maintain TomEE 7 for those that want it. I'd be happy to go
> > > > through
> > > > > JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> > > >
> > > >
> > >
> >
> >
> >
>
Re: [DISCUSS] switching TomEE8 to master
Posted by Romain Manni-Bucau <rm...@gmail.com>.
(Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
member of the community review it since, as you mentionned, idea was coming
from me but happy to apply it after.
Le 15 avr. 2018 22:28, "Jonathan Gallimore" <jo...@gmail.com>
a écrit :
> Hi,
>
> This discussion originated on the TomEE dev@ list, but I think it is more
> appropriate that it continue here. Effectively I'm looking at trying to
> provide a 1.0.1 version of Johnzon that is at the the same API level as
> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
> release.
>
> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
> over the next couple of days, but I'd welcome any feedback.
>
> Many thanks
>
> Jon
>
> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
> jonathan.gallimore@gmail.com> wrote:
>
> > Happy to try that. I'll give that a go this evening. I misunderstood your
> > proposal, but it makes sense now.
> >
> > Cheers
> >
> > Jo
> >
> > On 1 Apr 2018 17:41, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
> >
> > What about my proposal? Take johnzon master, copy it over 1.0.x and
> > downgrade apis? It is probably the safest and shouldnt be long to make
> > work. Can help next week if needed.
> >
> > Le 1 avr. 2018 17:06, "Jonathan Gallimore" <jonathan.gallimore@gmail.com
> >
> > a
> > écrit :
> >
> > > Agreed. I'll start working on the list of fixes tonight.
> > >
> > > Jon
> > >
> > > On Sun, 1 Apr 2018, 16:02 Mark Struberg, <st...@yahoo.de.invalid>
> > > wrote:
> > >
> > > > Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
> > Java8
> > > > as min version).
> > > >
> > > > And I'd also happily volunteer to release Johnzon-1.0.1.
> > > >
> > > > BUT, first we need to check which Johnzon bugfixes are necessary to
> > > > backport!
> > > > Then let's create tickets for that version and solve them.
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > > > Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> > > > jonathan.gallimore@gmail.com>:
> > > > >
> > > > > I think getting TomEE 8 out is obviously is preferred option. I
> would
> > > > still
> > > > > like to maintain TomEE 7 for those that want it. I'd be happy to go
> > > > through
> > > > > JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> > > >
> > > >
> > >
> >
> >
> >
>
Re: [DISCUSS] switching TomEE8 to master
Posted by Romain Manni-Bucau <rm...@gmail.com>.
(Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
member of the community review it since, as you mentionned, idea was coming
from me but happy to apply it after.
Le 15 avr. 2018 22:28, "Jonathan Gallimore" <jo...@gmail.com>
a écrit :
> Hi,
>
> This discussion originated on the TomEE dev@ list, but I think it is more
> appropriate that it continue here. Effectively I'm looking at trying to
> provide a 1.0.1 version of Johnzon that is at the the same API level as
> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
> release.
>
> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
> over the next couple of days, but I'd welcome any feedback.
>
> Many thanks
>
> Jon
>
> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
> jonathan.gallimore@gmail.com> wrote:
>
> > Happy to try that. I'll give that a go this evening. I misunderstood your
> > proposal, but it makes sense now.
> >
> > Cheers
> >
> > Jo
> >
> > On 1 Apr 2018 17:41, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
> >
> > What about my proposal? Take johnzon master, copy it over 1.0.x and
> > downgrade apis? It is probably the safest and shouldnt be long to make
> > work. Can help next week if needed.
> >
> > Le 1 avr. 2018 17:06, "Jonathan Gallimore" <jonathan.gallimore@gmail.com
> >
> > a
> > écrit :
> >
> > > Agreed. I'll start working on the list of fixes tonight.
> > >
> > > Jon
> > >
> > > On Sun, 1 Apr 2018, 16:02 Mark Struberg, <st...@yahoo.de.invalid>
> > > wrote:
> > >
> > > > Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
> > Java8
> > > > as min version).
> > > >
> > > > And I'd also happily volunteer to release Johnzon-1.0.1.
> > > >
> > > > BUT, first we need to check which Johnzon bugfixes are necessary to
> > > > backport!
> > > > Then let's create tickets for that version and solve them.
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > > > Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> > > > jonathan.gallimore@gmail.com>:
> > > > >
> > > > > I think getting TomEE 8 out is obviously is preferred option. I
> would
> > > > still
> > > > > like to maintain TomEE 7 for those that want it. I'd be happy to go
> > > > through
> > > > > JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> > > >
> > > >
> > >
> >
> >
> >
>