You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/03/24 20:09:30 UTC
Review Request 45306: ambari-server check-database has errors after
upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
Bugs: AMBARI-15568
https://issues.apache.org/jira/browse/AMBARI-15568
Repository: ambari
Description
-------
STR: Gateway: 172.22.74.38:8080
1)Deploy old version
2)Make Ambari only Upgrade
4)'ambari-server check-database'
2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
Diff: https://reviews.apache.org/r/45306/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 45306: ambari-server check-database has errors
after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/#review125323
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Березень 24, 2016, 9:35 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45306/
> -----------------------------------------------------------
>
> (Updated Березень 24, 2016, 9:35 після полудня)
>
>
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15568
> https://issues.apache.org/jira/browse/AMBARI-15568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR: Gateway: 172.22.74.38:8080
> 1)Deploy old version
> 2)Make Ambari only Upgrade
> 4)'ambari-server check-database'
> 2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
> 2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
> 2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
> ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
>
> Diff: https://reviews.apache.org/r/45306/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 45306: ambari-server check-database has errors
after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/#review125328
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 24, 2016, 7:54 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45306/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 7:54 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15568
> https://issues.apache.org/jira/browse/AMBARI-15568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR: Gateway: 172.22.74.38:8080
> 1)Deploy old version
> 2)Make Ambari only Upgrade
> 4)'ambari-server check-database'
> 2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
> 2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
> 2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
> ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
>
> Diff: https://reviews.apache.org/r/45306/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 45306: ambari-server check-database has errors
after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/
-----------------------------------------------------------
(Updated Березень 24, 2016, 7:54 після полудня)
Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
Bugs: AMBARI-15568
https://issues.apache.org/jira/browse/AMBARI-15568
Repository: ambari
Description
-------
STR: Gateway: 172.22.74.38:8080
1)Deploy old version
2)Make Ambari only Upgrade
4)'ambari-server check-database'
2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
Diff: https://reviews.apache.org/r/45306/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 45306: ambari-server check-database has errors
after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/#review125325
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java (line 199)
<https://reviews.apache.org/r/45306/#comment188099>
Add a comment as to why this is needed
- Alejandro Fernandez
On March 24, 2016, 7:35 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45306/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 7:35 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15568
> https://issues.apache.org/jira/browse/AMBARI-15568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR: Gateway: 172.22.74.38:8080
> 1)Deploy old version
> 2)Make Ambari only Upgrade
> 4)'ambari-server check-database'
> 2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
> 2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
> 2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
> ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
>
> Diff: https://reviews.apache.org/r/45306/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 45306: ambari-server check-database has errors
after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/
-----------------------------------------------------------
(Updated Березень 24, 2016, 7:35 після полудня)
Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
Bugs: AMBARI-15568
https://issues.apache.org/jira/browse/AMBARI-15568
Repository: ambari
Description
-------
STR: Gateway: 172.22.74.38:8080
1)Deploy old version
2)Make Ambari only Upgrade
4)'ambari-server check-database'
2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
Diff: https://reviews.apache.org/r/45306/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 45306: ambari-server check-database has errors
after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
> On Березень 24, 2016, 9:17 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, line 196
> > <https://reviews.apache.org/r/45306/diff/1/?file=1314129#file1314129line196>
> >
> > So creating the new service config version will automatically add slider-site to the list?
Yes, this method creates new service config version from currently applied cluster config mappings.
- Myroslav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/#review125319
-----------------------------------------------------------
On Березень 24, 2016, 9:09 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45306/
> -----------------------------------------------------------
>
> (Updated Березень 24, 2016, 9:09 після полудня)
>
>
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15568
> https://issues.apache.org/jira/browse/AMBARI-15568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR: Gateway: 172.22.74.38:8080
> 1)Deploy old version
> 2)Make Ambari only Upgrade
> 4)'ambari-server check-database'
> 2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
> 2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
> 2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
> ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
>
> Diff: https://reviews.apache.org/r/45306/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 45306: ambari-server check-database has errors
after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/#review125319
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java (line 196)
<https://reviews.apache.org/r/45306/#comment188097>
So creating the new service config version will automatically add slider-site to the list?
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java (line 199)
<https://reviews.apache.org/r/45306/#comment188096>
Nit: Typo - SLIDE to SLIDER in the text.
- Sumit Mohanty
On March 24, 2016, 7:09 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45306/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 7:09 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15568
> https://issues.apache.org/jira/browse/AMBARI-15568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR: Gateway: 172.22.74.38:8080
> 1)Deploy old version
> 2)Make Ambari only Upgrade
> 4)'ambari-server check-database'
> 2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
> 2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
> 2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
> ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
>
> Diff: https://reviews.apache.org/r/45306/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 45306: ambari-server check-database has errors
after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45306/#review125321
-----------------------------------------------------------
Ship it!
Fix the minor type and ship.
- Sumit Mohanty
On March 24, 2016, 7:09 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45306/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 7:09 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15568
> https://issues.apache.org/jira/browse/AMBARI-15568
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR: Gateway: 172.22.74.38:8080
> 1)Deploy old version
> 2)Make Ambari only Upgrade
> 4)'ambari-server check-database'
> 2016-03-23 10:22:31,276 INFO - ******************************* Check database started *******************************
> 2016-03-23 10:22:56,229 ERROR - Required config(s): slider-client is(are) not available for service SLIDER with service config version 1 in cluster cl1
> 2016-03-23 10:22:56,469 INFO - ******************************* Check database completed *******************************
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7601e4c
> ambari-server/src/main/python/ambari_server/checkDatabase.py 2deca0a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 17d7e4e
>
> Diff: https://reviews.apache.org/r/45306/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>