You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/07/31 00:36:58 UTC

(texera) branch gh-readonly-queue/main/pr-7134-68389937f0d761fa36ba167edfb08f21515303d7 created (now 91ed98d78e)

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-7134-68389937f0d761fa36ba167edfb08f21515303d7
in repository https://gitbox.apache.org/repos/asf/texera.git


      at 91ed98d78e docs(config): fix stale paths in gui.conf add-config guide (#7134)

This branch includes the following new commits:

     new 91ed98d78e docs(config): fix stale paths in gui.conf add-config guide (#7134)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(texera) 01/01: docs(config): fix stale paths in gui.conf add-config guide (#7134)

Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-7134-68389937f0d761fa36ba167edfb08f21515303d7
in repository https://gitbox.apache.org/repos/asf/texera.git

commit 91ed98d78e4eaf7f13755fd8233666ae6089c6e5
Author: Yicong Huang <17...@users.noreply.github.com>
AuthorDate: Thu Jul 30 20:36:36 2026 -0400

    docs(config): fix stale paths in gui.conf add-config guide (#7134)
    
    ### What changes were proposed in this PR?
    
    The "to add a new configuration" guide atop gui.conf pointed to two
    paths that no longer exist. Step 2 named a GuiConfig.scala location
    under core/config, but the parser now lives under common/config. Step 3
    named a sending step in an old UserConfigResource.scala, but config
    values are now served from ConfigResource.scala in the config-service
    module. Both steps now match the current layout so contributors
    following the guide edit the right files.
    
    ### Any related issues, documentation, discussions?
    
    Closes #7133
    
    ### How was this PR tested?
    
    Comment-only change; confirmed the two referenced files exist at the
    updated paths.
    
    ### Was this PR authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (Claude Opus 4.8)
    
    Co-authored-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
 common/config/src/main/resources/gui.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/config/src/main/resources/gui.conf b/common/config/src/main/resources/gui.conf
index 1e500dd35c..b9908304fb 100644
--- a/common/config/src/main/resources/gui.conf
+++ b/common/config/src/main/resources/gui.conf
@@ -18,8 +18,8 @@
 # This file is used to configure the GUI shown in users' browser.
 # To add a new configuration:
 #   1. Add a new property, its default value and the environment variable name in the gui section in this file
-#   2. Add the corresponding parsing logic in core/config/src/main/scala/org/apache/texera/config/GuiConfig.scala
-#   3. Add the sending logic in core/src/main/scala/org/apache/texera/web/resource/UserConfigResource.scala
+#   2. Add the corresponding parsing logic in common/config/src/main/scala/org/apache/texera/common/config/GuiConfig.scala
+#   3. Add the sending logic to the matching endpoint in config-service/src/main/scala/org/apache/texera/service/resource/ConfigResource.scala
 #   4. Add the frontend definition in frontend/src/app/common/type/gui-config.ts and frontend/src/app/common/service/gui-config.service.mock.ts
 # To change the default value of a configuration:
 #   1. Change the default value in the gui section in this file