You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:34:23 UTC
[GitHub] [kafka] govi20 opened a new pull request #9760: KAFKA-10850: Use 'Int.box' to replace deprecated 'new Integer' from BrokerToControllerRequestThreadTest
govi20 opened a new pull request #9760:
URL: https://github.com/apache/kafka/pull/9760
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] govi20 commented on pull request #9760: KAFKA-10850: Use 'Int.box' to replace deprecated 'new Integer' from BrokerToControllerRequestThreadTest
Posted by GitBox <gi...@apache.org>.
govi20 commented on pull request #9760:
URL: https://github.com/apache/kafka/pull/9760#issuecomment-747448792
> @govi20 It seems we don't need to box the primitive type as scala compiler complete the conversion for us, right?
Yes, seems we can replace `Int.box` with value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9760: KAFKA-10850: Use 'Int.box' to replace deprecated 'new Integer' from BrokerToControllerRequestThreadTest
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9760:
URL: https://github.com/apache/kafka/pull/9760#issuecomment-747184218
@govi20 It seems we don't need to box the primitive type as scala compiler complete the conversion for us, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9760: KAFKA-10850: Use 'Int.box' to replace deprecated 'new Integer' from BrokerToControllerRequestThreadTest
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9760:
URL: https://github.com/apache/kafka/pull/9760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] govi20 commented on pull request #9760: KAFKA-10850: Use 'Int.box' to replace deprecated 'new Integer' from BrokerToControllerRequestThreadTest
Posted by GitBox <gi...@apache.org>.
govi20 commented on pull request #9760:
URL: https://github.com/apache/kafka/pull/9760#issuecomment-746391613
Hi @chia7712 , can you please review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org