You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/07/01 21:03:22 UTC
[GitHub] [couchdb] nickva opened a new pull request, #4085: Add an option to let custodian always use [cluster] n value
nickva opened a new pull request, #4085:
URL: https://github.com/apache/couchdb/pull/4085
In cases when the application prevents creating dbs with non-default n values (n=1, n=2) setting `[custodian] use_cluster_n_as_max_n = true` can help detect case when the shard map itself was manpulated and by mistake ended up with less than `[cluster] n` copies for some ranges.
By default the behavior is unchanged and n value will be deduced from the number of copies indicated in the shard map documents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #4085: Add an option to let custodian always use [cluster] n value
Posted by GitBox <gi...@apache.org>.
nickva merged PR #4085:
URL: https://github.com/apache/couchdb/pull/4085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane commented on a diff in pull request #4085: Add an option to let custodian always use [cluster] n value
Posted by GitBox <gi...@apache.org>.
jaydoane commented on code in PR #4085:
URL: https://github.com/apache/couchdb/pull/4085#discussion_r914123778
##########
rel/overlay/etc/default.ini:
##########
@@ -753,3 +753,13 @@ port = {{prometheus_port}}
; to disable this setting could be if the views need an upgrade but located on
; read-only file system.
;commit_on_header_upgrade = true
+
+[custodian]
+; When set to `true`, force using `[cluster] n` values as the expected n value
+; of of shard copies. In cases where the application prevents creating
Review Comment:
Maybe replace "the application" with "custodian" for clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4085: Add an option to let custodian always use [cluster] n value
Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4085:
URL: https://github.com/apache/couchdb/pull/4085#discussion_r914138410
##########
rel/overlay/etc/default.ini:
##########
@@ -753,3 +753,13 @@ port = {{prometheus_port}}
; to disable this setting could be if the views need an upgrade but located on
; read-only file system.
;commit_on_header_upgrade = true
+
+[custodian]
+; When set to `true`, force using `[cluster] n` values as the expected n value
+; of of shard copies. In cases where the application prevents creating
Review Comment:
In this case it would be a the user's application which uses CouchDB underneath. Say, if they'd never be a chance to have any databases with `n=2` or `n=1`. But, there is a chance the shard map could be manipulated by hand (rebalancing shards, restoring backups, etc) and so we'd want custodian to warn about some missing copies. With the current scheme of taking n = `number of shard ranges in the shard map` it's impossible to check for that condition (but, instead we allow creating dbs with n < cluster n and don't flag that as an error in custodian).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org