You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2026/02/02 09:13:06 UTC
[PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
starocean999 opened a new pull request, #60440:
URL: https://github.com/apache/doris/pull/60440
This change fixes a logic bug in the Thrift plan builder where the set of computed "targets" could be incorrect, potentially producing invalid execution plans. The root cause was an error in the targets computation path in ThriftPlansBuilder.java which caused some targets to be lost.
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60440:
URL: https://github.com/apache/doris/pull/60440#issuecomment-3833897379
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60440:
URL: https://github.com/apache/doris/pull/60440#issuecomment-3834028832
<details>
<summary>TPC-H: <b>Total hot run time: 32386 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2fa92bb0744fc4e7ef9ec910b19cd57b186b8906, data reload: false
------ Round 1 ----------------------------------
q1 17634 5275 5037 5037
q2 2016 362 194 194
q3 10325 1323 740 740
q4 10247 842 335 335
q5 7582 2179 1847 1847
q6 197 180 148 148
q7 881 730 614 614
q8 9263 1428 1089 1089
q9 5194 4986 4876 4876
q10 6834 1971 1573 1573
q11 503 303 290 290
q12 335 369 225 225
q13 17801 4050 3280 3280
q14 236 243 222 222
q15 891 822 812 812
q16 690 687 623 623
q17 629 793 482 482
q18 6719 6644 7625 6644
q19 1460 1039 689 689
q20 445 372 239 239
q21 3021 2203 2133 2133
q22 383 328 294 294
Total cold run time: 103286 ms
Total hot run time: 32386 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5671 5626 5468 5468
q2 251 347 253 253
q3 2356 2880 2581 2581
q4 1424 1815 1426 1426
q5 4747 4543 4790 4543
q6 227 176 137 137
q7 1967 1990 1962 1962
q8 2526 2381 2426 2381
q9 7739 7584 7419 7419
q10 2776 2991 2573 2573
q11 555 465 445 445
q12 699 757 567 567
q13 3572 4014 3199 3199
q14 274 296 278 278
q15 834 785 794 785
q16 645 698 630 630
q17 1090 1294 1328 1294
q18 7686 7435 7237 7237
q19 862 804 829 804
q20 2002 2056 1897 1897
q21 4493 4208 4210 4208
q22 561 546 510 510
Total cold run time: 52957 ms
Total hot run time: 50597 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #60440:
URL: https://github.com/apache/doris/pull/60440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60440:
URL: https://github.com/apache/doris/pull/60440#issuecomment-3834108012
<details>
<summary>ClickBench: <b>Total hot run time: 28.23 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2fa92bb0744fc4e7ef9ec910b19cd57b186b8906, data reload: false
query1 0.05 0.05 0.05
query2 0.09 0.05 0.06
query3 0.26 0.08 0.09
query4 1.61 0.11 0.11
query5 0.27 0.26 0.24
query6 1.18 0.68 0.67
query7 0.03 0.03 0.03
query8 0.05 0.04 0.05
query9 0.57 0.50 0.50
query10 0.54 0.54 0.54
query11 0.14 0.09 0.10
query12 0.14 0.11 0.11
query13 0.63 0.60 0.61
query14 1.07 1.06 1.03
query15 0.89 0.88 0.86
query16 0.39 0.39 0.39
query17 1.08 1.17 1.09
query18 0.23 0.21 0.21
query19 2.08 2.05 2.03
query20 0.02 0.01 0.01
query21 15.41 0.27 0.15
query22 5.19 0.05 0.05
query23 16.09 0.30 0.12
query24 1.00 0.25 0.47
query25 0.12 0.08 0.06
query26 0.14 0.13 0.14
query27 0.07 0.09 0.06
query28 3.94 1.16 0.96
query29 12.55 3.91 3.15
query30 0.27 0.13 0.11
query31 2.81 0.65 0.40
query32 3.24 0.61 0.49
query33 3.30 3.20 3.22
query34 16.22 5.41 4.74
query35 4.80 4.77 4.81
query36 0.66 0.50 0.49
query37 0.11 0.07 0.07
query38 0.07 0.04 0.04
query39 0.04 0.03 0.02
query40 0.18 0.17 0.15
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 97.69 s
Total hot run time: 28.23 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #60440:
URL: https://github.com/apache/doris/pull/60440#issuecomment-3833897567
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60440:
URL: https://github.com/apache/doris/pull/60440#issuecomment-3838642649
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60440:
URL: https://github.com/apache/doris/pull/60440#issuecomment-3834693834
# FE Regression Coverage Report
Increment line coverage ` 100.00% (18/18)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60440_2fa92bb0744fc4e7ef9ec910b19cd57b186b8906_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60440_2fa92bb0744fc4e7ef9ec910b19cd57b186b8906_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](recursive_cte)Fix incorrect targets calculation in ThriftPlansBuilder [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60440:
URL: https://github.com/apache/doris/pull/60440#issuecomment-3838643030
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org