[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5782: [INLONG-5781][Manager] Support creating consumer groups for all sinks

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #5782:
URL: https://github.com/apache/inlong/pull/5782#discussion_r962783642


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/InlongConsumeServiceImpl.java:
##########
@@ -82,6 +84,36 @@ public Integer save(InlongConsumeRequest request, String operator) {
         return request.getId();
     }
 
+    @Override
+    public Integer saveBySystem(InlongGroupInfo groupInfo, String topic, String consumerGroup) {
+        String groupId = groupInfo.getInlongGroupId();
+        InlongConsumeEntity exists = consumeMapper.selectExists(groupId, topic, consumerGroup);
+        if (exists != null) {

Review Comment:
   Maybe it is better to return the exists id?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org