You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/14 05:46:27 UTC

[GitHub] [calcite] amaliujia commented on a change in pull request #1975: [CALCITE-3996] Fix NPE when query syntax is invalid (James Kim)

amaliujia commented on a change in pull request #1975:
URL: https://github.com/apache/calcite/pull/1975#discussion_r424883844



##########
File path: core/src/main/java/org/apache/calcite/sql/type/InferTypes.java
##########
@@ -67,6 +67,9 @@ private InferTypes() {}
    */
   public static final SqlOperandTypeInference RETURN_TYPE =
       (callBinding, returnType, operandTypes) -> {
+        if (returnType == null) {
+          return;

Review comment:
       Can this return nothing? Is the return type is "VOID" (seems not so)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org