You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org> on 2026/04/17 08:11:27 UTC

[PR] [core] Do not limit pushdown with filter is present [paimon]

XiaoHongbo-Hope opened a new pull request, #7665:
URL: https://github.com/apache/paimon/pull/7665

   ### Purpose
   
   ### Tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Do not pushdown limit when non partition filter is present [paimon]

Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope closed pull request #7665: [core] Do not pushdown limit when non partition filter is present
URL: https://github.com/apache/paimon/pull/7665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Do not pushdown limit when non partition filter is present [paimon]

Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #7665:
URL: https://github.com/apache/paimon/pull/7665#issuecomment-4267233547

   @wwj6591812 Could you please help take a look at this PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Do not pushdown limit when non partition filter is present [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #7665:
URL: https://github.com/apache/paimon/pull/7665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Do not pushdown limit when non partition filter is present [paimon]

Posted by "wwj6591812 (via GitHub)" <gi...@apache.org>.
wwj6591812 commented on PR #7665:
URL: https://github.com/apache/paimon/pull/7665#issuecomment-4277430596

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Do not pushdown limit when non partition filter is present [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #7665:
URL: https://github.com/apache/paimon/pull/7665#discussion_r3099913167


##########
paimon-core/src/main/java/org/apache/paimon/table/source/DataTableBatchScan.java:
##########
@@ -126,7 +132,7 @@ public List<PartitionEntry> listPartitionEntries() {
     }
 
     private Optional<StartingScanner.Result> applyPushDownLimit() {

Review Comment:
   Maybe this should be in `SnapshotReaderImpl`, `withFilter` already know if there is non-part filter. (`!pair.getRight().isEmpty()`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Do not pushdown limit when non partition filter is present [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #7665:
URL: https://github.com/apache/paimon/pull/7665#issuecomment-4268417334

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Do not pushdown limit when non partition filter is present [paimon]

Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #7665:
URL: https://github.com/apache/paimon/pull/7665#discussion_r3100219106


##########
paimon-core/src/main/java/org/apache/paimon/table/source/DataTableBatchScan.java:
##########
@@ -126,7 +132,7 @@ public List<PartitionEntry> listPartitionEntries() {
     }
 
     private Optional<StartingScanner.Result> applyPushDownLimit() {

Review Comment:
   > Maybe this should be in `SnapshotReaderImpl`, `withFilter` already know if there is non-part filter. (`!pair.getRight().isEmpty()`)
   
   Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org