You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/06 05:43:51 UTC

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3868: Part of the shard key in multiple sharding policies can be null

KomachiSion commented on issue #3868: Part of the shard key in multiple sharding policies can be null
URL: https://github.com/apache/incubator-shardingsphere/pull/3868#issuecomment-571012238
 
 
   @lyzhb9014 , Sorry, My mistake. I read the issue again, and I found there are some error  in this implementation.
   
   1. this implementation will cause insert with null value full-routing for one record.
   2. Even just for ComplexShardingStrategy, the null value also can't be input to sharding algorithm.
   
   So we can't accept this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services