You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/04/25 17:25:14 UTC
[GitHub] [nifi] MarcyGO opened a new pull request, #5996: NIFI-9964: Change assertion to prevent TestLookupRecord from failing due to indeterminate map ordering
MarcyGO opened a new pull request, #5996:
URL: https://github.com/apache/nifi/pull/5996
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
#### Description of PR
The test `org.apache.nifi.processors.standard.TestLookupRecord#testAddFieldsToExistingRecordRouteToSuccess` can fail based on the order of iteration in `HashMap`.
In line 437 to 441:
```
final List<RecordField> fields = new ArrayList<>();
fields.add(new RecordField("favorite", RecordFieldType.STRING.getDataType(), false));
fields.add(new RecordField("least", RecordFieldType.STRING.getDataType(), true));
final RecordSchema schema = new SimpleRecordSchema(fields);
final Record sports = new MapRecord(schema, new HashMap<>());
```
It creates two ```RecordField``` ```favorite``` and ```least``` and adds them into ```Record``` ```sports```. Since ```sports``` is created by a HashMap, the order of ```favorite``` and ```least``` are indeterminate in ```sports```. Therefore, in the actual ```MockFlowFile``` content, the order of "soccer" and "basketball" is also indeterminate.
I found the issue using [NonDex](https://github.com/TestingResearchIllinois/NonDex):
```
mvn install -DskipTests -pl nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors -am
mvn -pl nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.apache.nifi.processors.standard.TestLookupRecord#testAddFieldsToExistingRecordRouteToSuccess
```
The proposed fix changes the assertion to endure the indeterminacy.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MarcyGO commented on a diff in pull request #5996: NIFI-9964: Change assertion to prevent TestLookupRecord from failing due to indeterminate map ordering
Posted by GitBox <gi...@apache.org>.
MarcyGO commented on code in PR #5996:
URL: https://github.com/apache/nifi/pull/5996#discussion_r861043360
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java:
##########
@@ -464,7 +464,9 @@ public void testAddFieldsToExistingRecordRouteToSuccess() throws InitializationE
runner.run();
final MockFlowFile out = runner.getFlowFilesForRelationship(LookupRecord.REL_SUCCESS).get(0);
- out.assertContentEquals("John Doe,48,soccer,basketball\nJane Doe,47\n");
+ assertTrue(out.getContent().equals("John Doe,48,soccer,basketball\nJane Doe,47\n")
+ || out.getContent().equals("John Doe,48,basketball,soccer\nJane Doe,47\n"));
Review Comment:
OK, I'll look into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #5996: NIFI-9964: Change assertion to prevent TestLookupRecord from failing due to indeterminate map ordering
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #5996:
URL: https://github.com/apache/nifi/pull/5996#issuecomment-1145128146
@MarcyGO It may be better to discuss a solution in the associated Jira issue. Given that the current PR does not implement a workable solution, please submit a new PR when ready and it can be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #5996: NIFI-9964: Change assertion to prevent TestLookupRecord from failing due to indeterminate map ordering
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #5996:
URL: https://github.com/apache/nifi/pull/5996#discussion_r861035075
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java:
##########
@@ -464,7 +464,9 @@ public void testAddFieldsToExistingRecordRouteToSuccess() throws InitializationE
runner.run();
final MockFlowFile out = runner.getFlowFilesForRelationship(LookupRecord.REL_SUCCESS).get(0);
- out.assertContentEquals("John Doe,48,soccer,basketball\nJane Doe,47\n");
+ assertTrue(out.getContent().equals("John Doe,48,soccer,basketball\nJane Doe,47\n")
+ || out.getContent().equals("John Doe,48,basketball,soccer\nJane Doe,47\n"));
Review Comment:
On further review, `assertContentEquals()` should remain unchanged, but it looks like `TestLookupRecord` should be updated to use `LinkedHashMap` instead of `HashMap` in several places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MarcyGO commented on a diff in pull request #5996: NIFI-9964: Change assertion to prevent TestLookupRecord from failing due to indeterminate map ordering
Posted by GitBox <gi...@apache.org>.
MarcyGO commented on code in PR #5996:
URL: https://github.com/apache/nifi/pull/5996#discussion_r861017432
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java:
##########
@@ -464,7 +464,9 @@ public void testAddFieldsToExistingRecordRouteToSuccess() throws InitializationE
runner.run();
final MockFlowFile out = runner.getFlowFilesForRelationship(LookupRecord.REL_SUCCESS).get(0);
- out.assertContentEquals("John Doe,48,soccer,basketball\nJane Doe,47\n");
+ assertTrue(out.getContent().equals("John Doe,48,soccer,basketball\nJane Doe,47\n")
+ || out.getContent().equals("John Doe,48,basketball,soccer\nJane Doe,47\n"));
Review Comment:
Do you mean I should modify the `assertContentEquals()` method so it ignores the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #5996: NIFI-9964: Change assertion to prevent TestLookupRecord from failing due to indeterminate map ordering
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #5996:
URL: https://github.com/apache/nifi/pull/5996#discussion_r858005844
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java:
##########
@@ -464,7 +464,9 @@ public void testAddFieldsToExistingRecordRouteToSuccess() throws InitializationE
runner.run();
final MockFlowFile out = runner.getFlowFilesForRelationship(LookupRecord.REL_SUCCESS).get(0);
- out.assertContentEquals("John Doe,48,soccer,basketball\nJane Doe,47\n");
+ assertTrue(out.getContent().equals("John Doe,48,soccer,basketball\nJane Doe,47\n")
+ || out.getContent().equals("John Doe,48,basketball,soccer\nJane Doe,47\n"));
Review Comment:
The test class should continue to use the `assertContentEquals()` method on `MockFlowFile`, as opposed to checking different values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5996: NIFI-9964: Change assertion to prevent TestLookupRecord from failing due to indeterminate map ordering
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #5996: NIFI-9964: Change assertion to prevent TestLookupRecord from failing due to indeterminate map ordering
URL: https://github.com/apache/nifi/pull/5996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org