Re: svn commit: r911864 - /xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/image/loader/pipeline/PipelineFactory.java

[Jeremias Maerki <de...@jeremias-maerki.ch>]

Hi Vincent

On 22.02.2010 13:41:01 Vincent Hennebert wrote:
<snip/>
> Why do you store all the pipelines in a collection if in the end you
> need only the best one?

The original idea was to have a prioritized list of pipelines that can
be tried if the first n pipelines fail to load an image. But then I just
switched to using a single one for now which may explain that.

> Also, do you have a test case to reproduce the issue? So that any
> further change does not introduce a regression.

With my recent additions there are now tests that should cover that.


Jeremias Maerki


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org