You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/18 02:18:02 UTC
[GitHub] [pulsar] sijie commented on a change in pull request #4062: Delayed
message delivery implementation
sijie commented on a change in pull request #4062: Delayed message delivery implementation
URL: https://github.com/apache/pulsar/pull/4062#discussion_r276497213
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -111,7 +111,10 @@ message MessageMetadata {
optional bytes encryption_param = 15;
optional bytes schema_version = 16;
- optional bool partition_key_b64_encoded = 17 [ default = false ];
+ optional bool partition_key_b64_encoded = 17 [ default = false ];
+
+ // Mark the message to be delivered at or after the specified timestamp
+ optional uint64 deliver_at_time = 18;
Review comment:
I would prefer using `int64` rather than `uint64` because Java doesn't have a unsigned int64.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services