You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/15 10:42:20 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#4764: refactor SelectStatementAssert
tristaZero opened a new pull request #4764: refactor SelectStatementAssert
URL: https://github.com/apache/incubator-shardingsphere/pull/4764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4764:
refactor SelectStatementAssert
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4764: refactor SelectStatementAssert
URL: https://github.com/apache/incubator-shardingsphere/pull/4764#issuecomment-599195776
## Pull Request Test Coverage Report for [Build 10254](https://coveralls.io/builds/29363987)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **59.41%**
---
| Totals | [](https://coveralls.io/builds/29363987) |
| :-- | --: |
| Change from base [Build 10253](https://coveralls.io/builds/29363394): | 0.0% |
| Covered Lines: | 12457 |
| Relevant Lines: | 20968 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4764:
refactor SelectStatementAssert
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4764: refactor SelectStatementAssert
URL: https://github.com/apache/incubator-shardingsphere/pull/4764#issuecomment-599193639
It is a considerable change, and please review it carefully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4764:
refactor SelectStatementAssert
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4764: refactor SelectStatementAssert
URL: https://github.com/apache/incubator-shardingsphere/pull/4764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4764: refactor SelectStatementAssert
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4764: refactor SelectStatementAssert
URL: https://github.com/apache/incubator-shardingsphere/pull/4764#issuecomment-599195776
## Pull Request Test Coverage Report for [Build 2105](https://coveralls.io/builds/29364017)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.08%**) to **59.486%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29364017/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/29364017) |
| :-- | --: |
| Change from base [Build 10253](https://coveralls.io/builds/29363394): | 0.08% |
| Covered Lines: | 12473 |
| Relevant Lines: | 20968 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4764:
refactor SelectStatementAssert
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4764: refactor SelectStatementAssert
URL: https://github.com/apache/incubator-shardingsphere/pull/4764#issuecomment-599195325
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4764?src=pr&el=h1) Report
> Merging [#4764](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4764?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/881634fc2e877442083682e51ac170a6d34762b2&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4764?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4764 +/- ##
=========================================
Coverage 55.87% 55.87%
Complexity 443 443
=========================================
Files 1156 1156
Lines 20968 20968
Branches 3879 3879
=========================================
Hits 11716 11716
Misses 8523 8523
Partials 729 729
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4764?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4764?src=pr&el=footer). Last update [881634f...25fd8cf](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4764?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services