[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #311: HDDS-2532. Sonar : fix issues in OzoneQuota

[GitBox <gi...@apache.org>]

anuengineer commented on a change in pull request #311: HDDS-2532. Sonar : fix issues in OzoneQuota
URL: https://github.com/apache/hadoop-ozone/pull/311#discussion_r354464827
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/OzoneQuota.java
 ##########
 @@ -136,10 +133,11 @@ public static OzoneQuota parseQuota(String quotaString)
       found = true;
     }
 
-    if (!found) {
-      throw new IllegalArgumentException(
-          "Quota unit not recognized. Supported values are BYTES, MB, GB and " +
-              "TB.");
+    if (Boolean.FALSE.equals(found)) {
 
 Review comment:
   and also, might be because I have not caught up with the new hip code styles; I find !found to be far easier to read than Boolean.FALSE.equals(found)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org