You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@htrace.apache.org by "Masatake Iwasaki (JIRA)" <ji...@apache.org> on 2017/05/17 03:08:04 UTC
[jira] [Comment Edited] (HTRACE-399) Exclude jackson from test
dependency on htrace-core4 to avoid infinite loop on creating
dependency-reduced-pom
[ https://issues.apache.org/jira/browse/HTRACE-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013444#comment-16013444 ]
Masatake Iwasaki edited comment on HTRACE-399 at 5/17/17 3:08 AM:
------------------------------------------------------------------
Though htrace-zipkin has similar dependency on htrace-core4, there was no issue.
{noformat}
<dependency>
<groupId>org.apache.htrace</groupId>
<artifactId>htrace-core4</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.htrace</groupId>
<artifactId>htrace-core4</artifactId>
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
{noformat}
The issue seems to be related to 'provided' scope depnedency in htrace-hbase.
{noformat}
<dependency>
<groupId>org.apache.htrace</groupId>
<artifactId>htrace-core4</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
{noformat}
Since I don't like classes of htrace-core4 is copied into shaded jar of htrace-hbase, I would like to keep this being 'provided'.
was (Author: iwasakims):
Though htrace-zipkin has similar dependency on htrace-core4, there was no issue.
{noformat}
<dependency>
<groupId>org.apache.htrace</groupId>
<artifactId>htrace-core4</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.htrace</groupId>
<artifactId>htrace-core4</artifactId>
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
{noformat}
The issue seems to be related to 'provided' scope depnedency in htrace-hbase.
{noformat}
<dependency>
<groupId>org.apache.htrace</groupId>
<artifactId>htrace-core4</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
{noformat}
Since I don't like classes of htrace-core4 is copied into shaded jar of htrace-hbase, I would not like to this scope to 'compile'.
> Exclude jackson from test dependency on htrace-core4 to avoid infinite loop on creating dependency-reduced-pom
> --------------------------------------------------------------------------------------------------------------
>
> Key: HTRACE-399
> URL: https://issues.apache.org/jira/browse/HTRACE-399
> Project: HTrace
> Issue Type: Bug
> Components: htrace-hbase
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Attachments: HTRACE-399.001.patch
>
>
> This is follow-up of HTRACE-234. As it is descrived in MSHADE-148, depending both of main and test jar of htrace-core4 causes the infinite loop on creating dependency-reduced-pom. I found that the loop is on adding jackson-core and jackson-databind to exclusions. Excluding jackson from test dependency to htrace-core4 fixed the issue. Since htrace-core4 has its own relocated jackson, htrace-hbase does not need the transitive dependency.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)