You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/02 11:26:51 UTC

[GitHub] [flink] matriv opened a new pull request, #19622: [hotfix][table] Remove implicit set of legacy cast to DISABLED

matriv opened a new pull request, #19622:
URL: https://github.com/apache/flink/pull/19622

   ## What is the purpose of the change
   
   With https://github.com/apache/flink/pull/19020 `DISABLED` is the
   default configuration for `table.exec.legacy-cast-behaviour`, so
   there is no need to explicitely set it in tests, as this can also be
   confusing (one could suspect that we are overriding the default value)
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19622: [hotfix][table] Remove implicit set of legacy cast to DISABLED

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19622:
URL: https://github.com/apache/flink/pull/19622#issuecomment-1114746300

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9df719451217de30b5fbc24bf5364d8583427ac0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9df719451217de30b5fbc24bf5364d8583427ac0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9df719451217de30b5fbc24bf5364d8583427ac0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] matriv commented on pull request #19622: [hotfix][table] Remove implicit set of legacy cast to DISABLED

Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19622:
URL: https://github.com/apache/flink/pull/19622#issuecomment-1117024827

   @MartijnVisser could you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org