You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/27 02:09:44 UTC
[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5233
Change subject: Allow to skip the scan part of full_stack-insert-scan-test
......................................................................
Allow to skip the scan part of full_stack-insert-scan-test
This test is good to microbenchmark/run perf on writes but
the scan part of the test introduces noise in this case.
This patch adds a flag to allow to skip the scan part of
the test.
Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
---
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/5233/1
--
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5233
to look at the new patch set (#2).
Change subject: Allow to skip the scan part of full_stack-insert-scan-test
......................................................................
Allow to skip the scan part of full_stack-insert-scan-test
This test is good to microbenchmark/run perf on writes but
the scan part of the test introduces noise in this case.
This patch adds a flag to allow to skip the scan part of
the test.
Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
---
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/5233/2
--
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Allow to skip the scan part of full_stack-insert-scan-test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Allow to skip the scan part of full_stack-insert-scan-test
......................................................................
Allow to skip the scan part of full_stack-insert-scan-test
This test is good to microbenchmark/run perf on writes but
the scan part of the test introduces noise in this case.
This patch adds a flag to allow to skip the scan part of
the test.
Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Reviewed-on: http://gerrit.cloudera.org:8080/5233
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Allow to skip the scan part of full_stack-insert-scan-test
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5233/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc
File src/kudu/integration-tests/full_stack-insert-scan-test.cc:
PS1, Line 275: NO_FATALS(DoTestScans());
: }
:
: TES
> nit: may be, move this into the DoTestScans() itself?
Done
PS1, Line 286: vector<scoped_refptr<Thread> > threads(kNumInsertClients);
: CountDownLatch start_latch(kNumInsertClients + 1);
: for (int i = 0; i < kNumInsertClients; ++i) {
:
> ditto
Done
--
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Allow to skip the scan part of full_stack-insert-scan-test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Allow to skip the scan part of full_stack-insert-scan-test
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5233/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc
File src/kudu/integration-tests/full_stack-insert-scan-test.cc:
PS1, Line 275: if (FLAGS_skip_scans) {
: LOG(INFO) << "Skipped scan part of the test.";
: return;
: }
nit: may be, move this into the DoTestScans() itself?
PS1, Line 286: if (FLAGS_skip_scans) {
: LOG(INFO) << "Skipped scan part of the test.";
: return;
: }
ditto
--
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes