You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "Gallardot (via GitHub)" <gi...@apache.org> on 2023/05/09 02:49:17 UTC

[GitHub] [apisix-helm-chart] Gallardot opened a new pull request, #543: chore: upgrade APISIX to 3.3.0

Gallardot opened a new pull request, #543:
URL: https://github.com/apache/apisix-helm-chart/pull/543

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] leslie-tsang commented on a diff in pull request #543: chore: upgrade APISIX to 3.3.0

Posted by "leslie-tsang (via GitHub)" <gi...@apache.org>.

leslie-tsang commented on code in PR #543:
URL: https://github.com/apache/apisix-helm-chart/pull/543#discussion_r1189548837


##########
.gitignore:
##########
@@ -1,4 +1,5 @@
 .idea/
+.vscode/
 .DS_Store
 test_**.yaml
 .history

Review Comment:
   Need a new line at the end of the file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] Gallardot commented on pull request #543: chore: upgrade APISIX to 3.3.0

Posted by "Gallardot (via GitHub)" <gi...@apache.org>.

Gallardot commented on PR #543:
URL: https://github.com/apache/apisix-helm-chart/pull/543#issuecomment-1541249261

   > Change the default router from `radixtree_uri` to `radixtree_host_uri`. Perhaps we should be consistent with APISIX?
   > 
   > https://github.com/apache/apisix-helm-chart/blob/5092739f02dd9d29587ed319f797f23e0992c019/charts/apisix/values.yaml#L65-L69
   > 
   > https://github.com/apache/apisix/blob/master/CHANGELOG.md#change
   
   Done. PTAL. @AlinsRan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #543: chore: upgrade APISIX to 3.3.0

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.

tao12345666333 commented on PR #543:
URL: https://github.com/apache/apisix-helm-chart/pull/543#issuecomment-1543243773

   I'm not certain if there have been any other configuration changes. Could you please make a check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #543: chore: upgrade APISIX to 3.3.0

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.

tao12345666333 merged PR #543:
URL: https://github.com/apache/apisix-helm-chart/pull/543


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] Gallardot commented on pull request #543: chore: upgrade APISIX to 3.3.0

Posted by "Gallardot (via GitHub)" <gi...@apache.org>.

Gallardot commented on PR #543:
URL: https://github.com/apache/apisix-helm-chart/pull/543#issuecomment-1543278185

   > I'm not certain if there have been any other configuration changes. Could you please make a check?
   
   Sure, after inspecting the [changelog documentation](https://github.com/apache/apisix/blob/master/CHANGELOG.md#330) shows that [#9047](https://github.com/apache/apisix/pull/9047) is the only breaking change that involves a default configuration item.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-helm-chart] AlinsRan commented on pull request #543: chore: upgrade APISIX to 3.3.0

Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.

AlinsRan commented on PR #543:
URL: https://github.com/apache/apisix-helm-chart/pull/543#issuecomment-1541165718

   Change the default router from radixtree_uri to radixtree_host_uri.
   Perhaps we should be consistent with APISIX?
    
   https://github.com/apache/apisix-helm-chart/blob/5092739f02dd9d29587ed319f797f23e0992c019/charts/apisix/values.yaml#L65-L69
   
   https://github.com/apache/apisix/blob/master/CHANGELOG.md#change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org