You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/08/17 22:15:31 UTC

[GitHub] [tinkerpop] lyndonbauto commented on pull request #1785: Export Result interface

lyndonbauto commented on PR #1785:
URL: https://github.com/apache/tinkerpop/pull/1785#issuecomment-1218543187

   @good41898 Hi there, thanks for using the Golang driver, cool to see people are putting it into things now.
   
   First off, did you need some help with running the tests? If you need more assistance there feel free to jump into the TinkerPop Discord and send us some more details, you can @ myself or yang to get our attention quicker.
   
   On the note of this code. I am unsure why this is required. The typical technique from my understanding of Golang (which I will admit is minimal) is to mock by making your own interface, for example: https://github.com/apache/tinkerpop/blob/master/gremlin-go/driver/gorillaTransporter_test.go#L35-L66
   
   Please correct my if I am wrong in my understanding. 
   
   Anyway I will approve your workflow to run since @xiazcy has suggested it might create some errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org