You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/17 08:21:18 UTC
[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request
#4714: Mxnet parser for Qnn dialect
anijain2305 commented on a change in pull request #4714: Mxnet parser for Qnn dialect
URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367814763
##########
File path: src/relay/qnn/op/convolution.cc
##########
@@ -57,7 +57,7 @@ bool QnnConv2DRel(const Array<Type>& types, int num_inputs, const Attrs& attrs,
CHECK(IsScalarType(types[2], DataType::Int(32))); // input_zero_point
CHECK(IsScalarType(types[3], DataType::Int(32))); // kernel_zero_point
CHECK(IsScalarType(types[4], DataType::Float(32))); // input_scale
- CHECK(IsScalarType(types[5], DataType::Float(32))); // kernel_scale
+ // AssignType(types[1], DataType::Float(32), data->shape[axis], reporter); // kernel_scale
Review comment:
Handled in a separate PR - https://github.com/apache/incubator-tvm/pull/4732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services