[GitHub] [kafka] divijvaidya commented on a diff in pull request #13784: MINOR: Fix for MetadataQuorumCommandErrorTest.testRelativeTimeMs

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on code in PR #13784:
URL: https://github.com/apache/kafka/pull/13784#discussion_r1211479979


##########
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandErrorTest.java:
##########
@@ -53,12 +53,14 @@ public void testDescribeOptions() {
 
     @Test
     public void testRelativeTimeMs() {
+        long validEpochMs = Instant.now().minusSeconds(5).toEpochMilli();
+        assertTrue(MetadataQuorumCommand.relativeTimeMs(validEpochMs, "test") >= 0);
         long nowMs = Instant.now().toEpochMilli();
         assertTrue(MetadataQuorumCommand.relativeTimeMs(nowMs, "test") >= 0);
-        long invalidEpochMs = Instant.EPOCH.minus(1, ChronoUnit.DAYS).toEpochMilli();
+        long invalidEpochMs = Instant.EPOCH.minusSeconds(86400).toEpochMilli();

Review Comment:
   nit
   Why did we change this? `minus(1, ChronoUnit.DAYS)` was much more readable than `minusSeconds(86400)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org