You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ayush00git (via GitHub)" <gi...@apache.org> on 2025/12/17 08:25:24 UTC
[PR] fix: toggle theme switch appearing on the website pages [apisix-website]
ayush00git opened a new pull request, #1978:
URL: https://github.com/apache/apisix-website/pull/1978
Fixes: #1977
Changes:
1. Removed the desktop rule that hid `.react-toggle` in `website/src/css/customTheme.scss`, so the theme switch is now visible in the navbar on all pages.
2. Removed `ThemeResetComponent` from `website/src/pages/index.tsx`, which previously forced light mode and manually hid the toggle via DOM queries. The component was forcing light theme whenever the home page was being opened.
Result:
The color mode switch now appears and works consistently across the whole website, matching the behavior of the Blog and Case Studies page.
Screenshots of the change:
<img width="1915" height="653" alt="image" src="https://github.com/user-attachments/assets/2a96d5f3-8ad7-4658-997b-596b851d739e" />
<img width="1915" height="653" alt="Screenshot From 2025-12-17 13-53-41" src="https://github.com/user-attachments/assets/541a4e1f-2d31-4303-9209-b58ebb6757c2" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: toggle theme switch appearing on the website pages [apisix-website]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #1978:
URL: https://github.com/apache/apisix-website/pull/1978#issuecomment-3695828915
Hey @guoqqqi @LiteSun
Could you please take a look into this PR.
waiting for your response...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: toggle theme switch appearing on the website pages [apisix-website]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #1978:
URL: https://github.com/apache/apisix-website/pull/1978#issuecomment-3669372281
Hey @yzeng25 can you please review the PR, and please let me know if there are any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: toggle theme switch appearing on the website pages [apisix-website]
Posted by "yzeng25 (via GitHub)" <gi...@apache.org>.
yzeng25 commented on PR #1978:
URL: https://github.com/apache/apisix-website/pull/1978#issuecomment-3688335580
> Hey @yzeng25 can you please review the PR, and please let me know if there are any changes.
@ayush00git these 2 files are last modified by @guoqqqi and @LiteSun in #1866 and #1894 , suggest asking them to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: toggle theme switch appearing on the website pages [apisix-website]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #1978:
URL: https://github.com/apache/apisix-website/pull/1978#issuecomment-3677384399
Hey @SkyeYoung @Baoyuantop
Can you please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: toggle theme switch appearing on the website pages [apisix-website]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #1978:
URL: https://github.com/apache/apisix-website/pull/1978#issuecomment-3688852063
Hey @guoqqqi @LiteSun
Please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org