You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/28 21:15:51 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter

Abacn commented on code in PR #22005:
URL: https://github.com/apache/beam/pull/22005#discussion_r908950043


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java:
##########
@@ -1021,13 +991,12 @@ void shutdown() throws Exception {
   public abstract static class BundleProcessor {
     public static BundleProcessor create(
         Cache<Object, Object> processWideCache,
-        InMemory bundleProgressReporterAndRegistrar,
+        BundleProgressReporter.InMemory bundleProgressReporterAndRegistrar,

Review Comment:
   I see, there are two "InMemory" which are subclass of different interface. If so then may remove the import of `org.apache.beam.fn.harness.control.BundleProgressReporter.InMemory` and also change all other raw InMemory to `BundleProgressReporter.InMemory` in this file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org