You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/21 16:28:26 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32623: [SPARK-34558][SQL][TESTS][FOLLOWUP] Fix a test to use a unknown filesystem
dongjoon-hyun commented on a change in pull request #32623:
URL: https://github.com/apache/spark/pull/32623#discussion_r637053501
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -473,15 +473,14 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach wit
}
}
- test("SPARK-33944: Create a working SparkSession with a broken FileSystem") {
+ test("SPARK-34558: Create a working SparkSession with a broken FileSystem") {
val msg = "Cannot qualify the warehouse path, leaving it unqualified"
val logAppender = new LogAppender(msg)
withLogAppender(logAppender) {
val session =
SparkSession.builder()
.master("local")
- .config(WAREHOUSE_PATH.key, "my_dir")
- .config("fs.file.impl", "non.existing.class")
+ .config(WAREHOUSE_PATH.key, "unknown:///mydir")
Review comment:
I noticed that the previous test code fails because it's not cause the expected exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org