You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/01/31 19:11:28 UTC

[GitHub] [zeppelin] javierivanov opened a new pull request #3621: [ZEPPELIN-4585] Add HTTP Cache-Control Header

javierivanov opened a new pull request #3621: [ZEPPELIN-4585] Add HTTP Cache-Control Header
URL: https://github.com/apache/zeppelin/pull/3621
 
 
   ### What is this PR for?
   A few sentences describing the overall goals of the pull request's commits.
   First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
   
   
   ### What type of PR is it?
   Improvement
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-4585
   
   ### How should this be tested?
   * Travis-ci should pass
   * To test the change:
   
   ```
   curl -i localhost:8080/api/version
   HTTP/1.1 200 OK
   Date: Fri, 31 Jan 2020 19:09:04 GMT
   Access-Control-Allow-Credentials: true
   Access-Control-Allow-Headers: authorization,Content-Type
   Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE
   X-FRAME-OPTIONS: SAMEORIGIN
   X-XSS-Protection: 1
   X-Content-Type-Options: nosniff
   Cache-Control: no-cache
   Content-Type: text/plain
   Content-Length: 144
   Server: Jetty(9.4.18.v20190429)
   
   {"status":"OK","message":"Zeppelin version","body":{"git-commit-id":"b4fc38a","git-timestamp":"2020-01-31 14:27:00","version":"0.9.0-SNAPSHOT"}}%  
   ```
   
   ### Questions:
   * Does the licenses files need update?
   No
   * Is there breaking changes for older versions?
   No
   * Does this needs documentation?
   Yes
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] alexott commented on issue #3621: [ZEPPELIN-4585] Add HTTP Cache-Control Header

Posted by GitBox <gi...@apache.org>.
alexott commented on issue #3621: [ZEPPELIN-4585] Add HTTP Cache-Control Header
URL: https://github.com/apache/zeppelin/pull/3621#issuecomment-581133456
 
 
   I'm not 100% sure that `Cache-Control` belongs to the CORS filter. Maybe we need to check, how it will affect the serving of the static assets, for example, from Helium bundles. Maybe it makes sense to add cache control as a separate filter that would distinguish between "static" and "dynamic" assets?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] javierivanov commented on issue #3621: [ZEPPELIN-4585] Add HTTP Cache-Control Header

Posted by GitBox <gi...@apache.org>.
javierivanov commented on issue #3621: [ZEPPELIN-4585] Add HTTP Cache-Control Header
URL: https://github.com/apache/zeppelin/pull/3621#issuecomment-581421953
 
 
   @alexott makes sense to me. I will check that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services