You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/12 19:09:25 UTC
[GitHub] [superset] betodealmeida opened a new pull request #13603: fix: default when adding tab_state.hide_left_bar
betodealmeida opened a new pull request #13603:
URL: https://github.com/apache/superset/pull/13603
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fix the creation of `tab_state.hide_left_bar` so that the default value is set in the DDL.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
N/A
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (182ff8d) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.98%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 70.94% -9.99%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29401 +9324
- Misses 4730 12042 +7312
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.46% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...8ec1f3c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (9ace2e6) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `12.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
===========================================
- Coverage 80.93% 68.79% -12.14%
===========================================
Files 304 825 +521
Lines 24807 41360 +16553
Branches 0 4276 +4276
===========================================
+ Hits 20077 28455 +8378
- Misses 4730 12905 +8175
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.41% <100.00%> (?)` | |
| hive | `?` | |
| mysql | `80.37% <ø> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.43% <ø> (-0.51%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `74.61% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| ... and [530 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (9ace2e6) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.96%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 70.96% -9.97%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29412 +9335
- Misses 4730 12031 +7301
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `?` | |
| mysql | `80.37% <ø> (ø)` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.51% <ø> (-0.42%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `68.91% <0.00%> (ø)` | |
| [...e/components/controls/MetricControl/AdhocMetric.js](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljLmpz) | `82.19% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (9ace2e6) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.78%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 71.15% -9.79%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29487 +9410
- Misses 4730 11956 +7226
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `80.05% <ø> (-0.02%)` | :arrow_down: |
| mysql | `80.37% <ø> (ø)` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.81% <ø> (-0.12%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `38.46% <0.00%> (ø)` | |
| [.../dashboard/util/charts/getEffectiveExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRFZmZlY3RpdmVFeHRyYUZpbHRlcnMudHM=) | `100.00% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `4.00% <0.00%> (ø)` | |
| [...perset-frontend/src/components/ChartIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uL2luZGV4LnRzeA==) | `50.00% <0.00%> (ø)` | |
| [...tend/src/dashboard/util/getFilterScopeNodesTree.js](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlTm9kZXNUcmVlLmpz) | `2.38% <0.00%> (ø)` | |
| [...ontend/src/dashboard/components/dnd/DragHandle.jsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnSGFuZGxlLmpzeA==) | `100.00% <0.00%> (ø)` | |
| ... and [518 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (9ace2e6) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.98%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 70.95% -9.99%
==========================================
Files 304 828 +524
Lines 24807 41415 +16608
Branches 0 4300 +4300
==========================================
+ Hits 20077 29385 +9308
- Misses 4730 12030 +7300
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `?` | |
| mysql | `80.37% <ø> (ø)` | |
| postgres | `80.41% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.49% <ø> (-0.44%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `74.61% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <0.00%> (-0.42%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [530 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (182ff8d) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.98%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 70.94% -9.99%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29401 +9324
- Misses 4730 12042 +7312
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.46% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (182ff8d) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.80%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 71.12% -9.81%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29476 +9399
- Misses 4730 11967 +7237
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `80.06% <ø> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.77% <ø> (-0.17%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <0.00%> (-0.45%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...s/nativeFilters/FilterBar/CascadeFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJDb250cm9sLnRzeA==) | `57.14% <0.00%> (ø)` | |
| [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `7.14% <0.00%> (ø)` | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (9ace2e6) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.78%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 71.15% -9.79%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29487 +9410
- Misses 4730 11956 +7226
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `80.07% <ø> (ø)` | |
| mysql | `80.37% <ø> (ø)` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.81% <ø> (-0.12%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `94.59% <0.00%> (ø)` | |
| [...rontend/src/filters/components/TimeColumn/types.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3R5cGVzLnRz) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5SGlzdG9yeS5qc3g=) | `50.00% <0.00%> (ø)` | |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `38.46% <0.00%> (ø)` | |
| [...end/src/components/Select/WindowedSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/util/findTabIndexByComponentId.js](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRUYWJJbmRleEJ5Q29tcG9uZW50SWQuanM=) | `85.71% <0.00%> (ø)` | |
| ... and [518 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (182ff8d) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `11.44%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
===========================================
- Coverage 80.93% 69.48% -11.45%
===========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
===========================================
+ Hits 20077 28798 +8721
- Misses 4730 12645 +7915
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.11% <100.00%> (?)` | |
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.46% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...8ec1f3c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (182ff8d) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.80%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 71.12% -9.81%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29477 +9400
- Misses 4730 11966 +7236
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `80.07% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.77% <ø> (-0.16%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <0.00%> (-0.45%)` | :arrow_down: |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `38.46% <0.00%> (ø)` | |
| [.../dashboard/util/charts/getEffectiveExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRFZmZlY3RpdmVFeHRyYUZpbHRlcnMudHM=) | `100.00% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `4.00% <0.00%> (ø)` | |
| [...perset-frontend/src/components/ChartIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uL2luZGV4LnRzeA==) | `50.00% <0.00%> (ø)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #13603:
URL: https://github.com/apache/superset/pull/13603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (182ff8d) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.73%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 71.19% -9.74%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29506 +9429
- Misses 4730 11937 +7207
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `80.07% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `80.10% <ø> (ø)` | |
| python | `80.89% <ø> (-0.05%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.01% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <0.00%> (-0.45%)` | :arrow_down: |
| [...d/src/dashboard/components/menu/ShareMenuItems.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMudHN4) | `25.00% <0.00%> (ø)` | |
| [...hboard/components/gridComponents/new/NewHeader.jsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdIZWFkZXIuanN4) | `100.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/RefreshIntervalModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLnRzeA==) | `63.33% <0.00%> (ø)` | |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `38.46% <0.00%> (ø)` | |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `100.00% <0.00%> (ø)` | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...ebb457c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org