[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #1679: Add fixed partitions
URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r332794448
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/PartitionKeyDesc.java
 ##########
 @@ -34,84 +34,121 @@
 public class PartitionKeyDesc implements Writable {
     // public static final PartitionKeyDesc MAX_VALUE = new PartitionKeyDesc();
     // lower values only be used for restore
-    private List<String> lowerValues;
-    private List<String> upperValues;
+    public enum PartitionRangeType {
+        INVALID,
+        LESS_THAN,
+        FIXED
+    }
 
+    private List<PartitionValue> lowerValues;
+    private List<PartitionValue> upperValues;
+    private PartitionRangeType partitionType;
     public static PartitionKeyDesc createMaxKeyDesc() {
         return new PartitionKeyDesc();
     }
 
     public PartitionKeyDesc() {
 
 Review comment:
   ```suggestion
       public PartitionKeyDesc() {
           partitionType = PartitionRangeType.LESS_THAN;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org