You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/01 23:48:46 UTC
Re: Review Request 70082: Converted `UUID` proto messages to
`id::UUID` in the RP manager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70082/
-----------------------------------------------------------
(Updated March 1, 2019, 11:48 p.m.)
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Changes
-------
Rebased.
Summary (updated)
-----------------
Converted `UUID` proto messages to `id::UUID` in the RP manager.
Repository: mesos
Description (updated)
-------
Since the RP manager might interact with an arbitrary resource provider,
it should convert a `UUID` proto message received in a
`UPDATE_PUBLISH_RESOURCES_STATUS` call into a `id::UUID`, and ignore the
call if its `UUID` is not valid.
Diffs (updated)
-----
src/resource_provider/manager.cpp 2cde62a1849b7d595841fb845033640b537b844d
Diff: https://reviews.apache.org/r/70082/diff/2/
Changes: https://reviews.apache.org/r/70082/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70082: Converted `UUID` proto messages to
`id::UUID` in the RP manager.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70082/#review213354
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70080, 70081, 70082]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2019, 3:48 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70082/
> -----------------------------------------------------------
>
> (Updated March 1, 2019, 3:48 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the RP manager might interact with an arbitrary resource provider,
> it should convert a `UUID` proto message received in a
> `UPDATE_PUBLISH_RESOURCES_STATUS` call into a `id::UUID`, and ignore the
> call if its `UUID` is not valid.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 2cde62a1849b7d595841fb845033640b537b844d
>
>
> Diff: https://reviews.apache.org/r/70082/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70082: Converted `UUID` proto messages to
`id::UUID` in the RP manager.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70082/#review213414
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70080, 70081, 70082]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2019, 11:48 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70082/
> -----------------------------------------------------------
>
> (Updated March 1, 2019, 11:48 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the RP manager might interact with an arbitrary resource provider,
> it should convert a `UUID` proto message received in a
> `UPDATE_PUBLISH_RESOURCES_STATUS` call into a `id::UUID`, and ignore the
> call if its `UUID` is not valid.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 2cde62a1849b7d595841fb845033640b537b844d
>
>
> Diff: https://reviews.apache.org/r/70082/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>