[jira] [Commented] (HDFS-5684) o.a.h.fs.viewfs.ViewFileSystem.MountPoint has no public methods.

["Andrew Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603704#comment-15603704 ] 

Andrew Wang commented on HDFS-5684:
-----------------------------------

Thanks for working on this Manoj, this looks good overall, a few comments:

* Is this a method that we want to expose to end user applications? It's possible this was just done for test purposes, which is why it's package-private. If so, we should just add some @VisibleForTesting annotations.
* If this is supposed to be user-accessible, then we should consider moving it to a separate VfsAdmin class, the way we have HdfsAdmin for special HDFS APIs. We shouldn't make our users downcast to access what's meant to be a public API.
* In the new test, I'd prefer if we used SLF4J rather than commons logging, SLF4J is our preferred logging library.

> o.a.h.fs.viewfs.ViewFileSystem.MountPoint has no public methods.
> ----------------------------------------------------------------
>
>                 Key: HDFS-5684
>                 URL: https://issues.apache.org/jira/browse/HDFS-5684
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Keith Turner
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-5684.01.patch
>
>
> o.a.h.fs.viewfs.ViewFileSystem provides the following method
> {noformat}
>   public MountPoint[] getMountPoints()
> {noformat}
> However MountPoint has no public methods making getMountPoints() useless.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org