[jira] [Resolved] (CALCITE-1558) AggregateExpandDistinctAggregatesRule gets field mapping wrong if groupKey is used in aggregate function

["Julian Hyde (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-1558.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.12.0

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/2b966375. Thanks for the PR, [~docete]!

> AggregateExpandDistinctAggregatesRule gets field mapping wrong if groupKey is used in aggregate function
> --------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1558
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1558
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Zhenghua Gao
>            Assignee: Julian Hyde
>             Fix For: 1.12.0
>
>         Attachments: patch_1558.v1
>
>
> In AggregateExpandDistinctAggregatesRule.convertSingletonDistinct,
> if the groupKey is also used in some aggregate function, 
> the field mapping of top level aggregate would be messy.
> Bad cases are:
> {noformat}
>         // Equivalent SQL:
>         //   SELECT deptno, COUNT(deptno), SUM(DISTINCT sal)
>         //   FROM emp
>         //   GROUP BY deptno
>         //   SELECT deptno, SUM(cnt), SUM(sal)
>         //   FROM
>         //     SELECT deptno, COUNT(deptno) AS cnt, sal
>         //     FROM emp
>         //     GROUP BY deptno, sal
>         //   GROUP BY deptno
> {noformat}
> or a more complex case:
> {noformat}
>         // Equivalent SQL:
>         //   SELECT deptno, SUM(deptno), SUM(DISTINCT sal), MAX(deptno), MAX(comm)
>         //   FROM emp
>         //   GROUP BY deptno
>         //   SELECT deptno, SUM(sumOfInnerComm), SUM(sal), MAX(maxOfInnerDeptno), MAX(maxOfInnerComm)
>         //   FROM
>         //     SELECT deptno, sal, SUM(deptno) as sumOfInnerDeptno, MAX(deptno) as maxOfInnerDeptno, MAX(comm) AS maxOfInnerComm
>         //     FROM emp
>         //     GROUP BY deptno, sal
>         //   GROUP BY deptno
> {noformat}
> I have fixed these cases, and will provide a patch later after more tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)